user2684

Results 241 comments of user2684

Excellent thanks! Let me review the chances during the weekend and I'll let you know. Of course I will wait for a first full implementation before merging it into the...

Hi, I see a bunch of limitations to this approach which makes me think we should tackle the problem from a different angle, which is getting deep into the atomic...

I see your point and appreciated it, yeah we need to think more strategically and potentially re-think the way NodeManager handles its sensors and children. I like the FSM idea....

I think it makes sense but I'd not touch Child; probably I'd add a sort of debounce at the specific sensor which may suffer from this. Thanks!

Yes, something like setInterruptDebounce() from #322 which is basically ignoring further interrupts for a given timeframe

Thanks for reporting it, adding to the v1.8 dev queue

@brahmafear I'm reviewing this in more details and seems weird the original code with `child->getType() == V_PERCENTAGE` is not working as expected. Are you sure you are sending the V_PERCENTAGE...

A simplified version can take out of the REQ message the time it is supposed to stay on

Sorry, I meant a SET message, depending on how setLegacyMode() is set. I was thinking of a first step before getting to the full scheduler which is pretty complex in...