[BUG] Version update is not aborted with multiple files

[CermakM]

The func which looks for version files (and also, confusingly enough, updates the versions in these files), the logger reports the following errors when multiple files are changed:

from look_for_version_files function:

    if len(changed) > 1:
        logger.error('Multiple version files found. Aborting version update.')
    elif not changed:
        logger.error('No version files found. Aborting version update.')

However, the version HAVE been changed already... what is the desired behaviour, then? Should multiple version files be updated? Should the update be aborted, or not?

[jpopelka]

and also, confusingly enough, updates the versions in these files

I see, some places are really confusing indeed.

what is the desired behaviour, then?

What do you think? I'd say that the len(changed) > 1 branch should be removed completely and leave just if not changed.

[CermakM]

Well, I am mainly confused about the Aborting version update. part (since there is nothing being 'aborted') there.

I'd say that the len(changed) > 1 branch should be removed completely and leave just if not changed.

+1, I think that updating multiple files is desired (altho it is not the best practice to have the version hardcoded in multiple places, some adventurers may do that anyway and we do want to bump all of these)

[jpopelka]

feel free to fix it then ;-)