colin icon indicating copy to clipboard operation
colin copied to clipboard

introduce dockerfile linting

Open TomasTomecek opened this issue 6 years ago • 4 comments

  • [ ] migrate all dockerfile checks from MTF over here

TomasTomecek avatar Apr 06 '18 09:04 TomasTomecek

MTF checks are:

  • [x] test_maintainer_label https://github.com/user-cont/colin/blob/master/colin/checks/labels/maintainer.py
  • [x] test_release_label https://github.com/user-cont/colin/blob/master/colin/checks/labels/release.py
  • [x] test_version_label https://github.com/user-cont/colin/blob/master/colin/checks/labels/version.py
  • [x] test_com_redhat_component_label https://github.com/user-cont/colin/blob/master/colin/checks/labels/com_redhat_component.py
  • [x] test_summary_label https://github.com/user-cont/colin/blob/master/colin/checks/labels/summary.py
  • [x] test_run_or_usage_label https://github.com/user-cont/colin/blob/master/colin/checks/labels/usage.py

Dockerfile related tests:

  • [ ] test_chained_run_dnf_commands https://github.com/user-cont/colin/issues/68
  • [ ] test_chained_run_rest_commands
  • [ ] test_copy_files_exist
  • [x] test_helpmd_is_present https://github.com/user-cont/colin/blob/master/colin/checks/best_practices/help_file.py

Image related tests:

  • [ ] test_all_no_docs
  • [ ] test_docker_clean_all https://github.com/user-cont/colin/issues/68
  • [ ] test_installed_docs

phracek avatar Apr 09 '18 08:04 phracek

This issue is about linting dockerfiles, none of that exists in colin yet, therefore I would untick all.

Thanks for the complete list, that's really helpful.

TomasTomecek avatar Apr 09 '18 10:04 TomasTomecek

We should discuss the list from Petr.

TomasTomecek avatar Apr 17 '18 07:04 TomasTomecek

Sorry, I resolved this automatically..

lachmanfrantisek avatar Apr 17 '18 09:04 lachmanfrantisek