colin icon indicating copy to clipboard operation
colin copied to clipboard

introduce checks which verify that Dockerfile doesn't contain labels which OSBS sets

Open TomasTomecek opened this issue 6 years ago • 2 comments

  • [ ] new class to check that a label is NOT present
  • [ ] release, architecture labels
  • [ ] a bunch of other labels from https://github.com/projectatomic/ContainerApplicationGenericLabels/blob/master/vendor/redhat/labels.md

This is a low-prio RFE, mainly added here just to track the problem.

TomasTomecek avatar May 25 '18 14:05 TomasTomecek

new class to check that a label is NOT present

This is already done -- you should only set required = False.

It should be something like this:

      "names": [
        "one",
        "two"
      ],
      "required": false,
      "message": "This label is automatically set by OSBS, do not set them in the Dockerfile.",
      "additional_tags": [
        "required",
         "osbs"
      ],
      "usable_targets": [
        "dockerfile"
      ]

lachmanfrantisek avatar May 25 '18 21:05 lachmanfrantisek

But still, we would have to create a new check (just tried this out).

Actually required confuses me a bit; probably should_be_present would make more sense.

TomasTomecek avatar May 28 '18 07:05 TomasTomecek