colin icon indicating copy to clipboard operation
colin copied to clipboard

Make sure check for presence of maintainer check works

Open TomasTomecek opened this issue 6 years ago • 4 comments

We've got a report internally that $subject does not work. Please investigate and ideally create a test case for this.

I am pretty sure the "WARN:Label 'maintainer' has to be specified." is a
false warning, unless I am blind and can not see the typo in my Dockerfile.

CC @fkluknav

Edit: I think I get it know, the message is wrong. We check whether the content matches a certain regex.

TomasTomecek avatar May 21 '18 11:05 TomasTomecek

LABEL maintainer="Red Hat, Inc." causes WARN:Label 'maintainer' has to be specified.

fkluknav avatar May 21 '18 12:05 fkluknav

Yeah, our regex is @redhat.com$. This is worth discussing internally.

TomasTomecek avatar May 21 '18 17:05 TomasTomecek

What is the standard for 'maintainer' label in images from Red Hat? Is there any? A person? A group? A company?

fkluknav avatar May 23 '18 14:05 fkluknav

Exactly, probably there is none. Therefore this should be brought up internally so we all agree on one standard.

@fkluknav Would you like to bring it up or should we take care of it?

TomasTomecek avatar May 24 '18 09:05 TomasTomecek