memos icon indicating copy to clipboard operation
memos copied to clipboard

Removed comment logic from memo_service

Open nathankrieger opened this issue 8 months ago • 3 comments

Closes #4677

Moves memo comment logic to its own service, shortening memo_service and aligning better with SRP

nathankrieger avatar May 07 '25 16:05 nathankrieger

@boojack Can I get some guidance on the failing check? I ran the commands to format.

nathankrieger avatar May 08 '25 21:05 nathankrieger

@nathankrieger Please follow the import order sample in https://github.com/usememos/memos/blob/main/server/router/api/v1/memo_service.go#L22

The order should be as follows:

// built-in packages
"context"
"fmt"

// third-party packages
"github.com/lithammer/shortuuid/v4"
"github.com/pkg/errors"

// local packages
"github.com/usememos/memos/server/runner/memopayload"
"github.com/usememos/memos/store"

johnnyjoygh avatar May 09 '25 06:05 johnnyjoygh

@nathankrieger There still has linter error, any updates?

johnnyjoygh avatar May 15 '25 07:05 johnnyjoygh