memos icon indicating copy to clipboard operation
memos copied to clipboard

it's possible to edit an old state of a note by not refreshing your browser first.

Open mea66 opened this issue 1 year ago • 3 comments

Describe the bug

I noticed a problem when editing the same note on different computers (with the same user):

  1. create a note on client 1
  2. edit this note on client 2
  3. go back to client 1 to edit (without refreshing the browser)
  4. you now have the old version in your edit window

Particularly problematic is the fact, that, even when I canceled the edit after realising it wasn't up-to-date, that old state still got saved and I lost the changes I made on the other machine.

I had this happen between 2 machines, but the same thing can be observed by using a private window.

Steps to reproduce

  1. create a note on client 1
  2. edit this note on client 2
  3. go back to client 1 and edit without refreshing the browser first
  4. you now have the old version in your edit window

The version of Memos you're using.

v0.22.5

Screenshots or additional context

No response

mea66 avatar Oct 27 '24 14:10 mea66

a side note (and probably a 2nd bug, but I don't know): I've just opened the moe memos app and my one "troublesome" note was still displaying the a wrong older state. Going back to the website, it has reverted too.. I lost my data now a second time :disappointed:

mea66 avatar Oct 27 '24 15:10 mea66

I will investigate this

monkeymatt0 avatar Oct 29 '24 15:10 monkeymatt0

There is no socket connection keeping 2 or more clients up to date as you type on each of them. You need to click save for the changes to be persisted and reload to see changes from other clients.

Memos had a local caching mechanism that keeps track of what you type locally until you click save or cancel. This is help in scenarios where you for e.g. close the tab before saving so you don't lose your data.

Moe memos is created and managed by a 3rd party ontop of memos APIs so the user experience is based on what they think is best and does not necessarily align with the memos web UI.

RoccoSmit avatar Oct 29 '24 20:10 RoccoSmit