memos icon indicating copy to clipboard operation
memos copied to clipboard

Allowing whitespace in create memo relation dialog

Open TheMaksym opened this issue 1 year ago • 2 comments

Proposing a solution for the issue regarding not being able to input whitespace in create memo relation dialog.

gif whitespace working

TheMaksym avatar Feb 12 '24 04:02 TheMaksym

Not exactly sure what error occurred on the front end test. This is in fact my first open source contribution so this is for sure a learning process.

TheMaksym avatar Feb 12 '24 04:02 TheMaksym

Not exactly sure what error occurred on the front end test. This is in fact my first open source contribution so this is for sure a learning process.

Hi @TheMaksym, the frontend test failed because you need to have new line at the very end of file after export default.

Steps to resolve this

  1. cd web
  2. run npm run lint --fix

or

manually enter a new line after export default ...

Then push the changes.

A general advice that I would give to you would be to run npm run lint and npm run lint --fix before you push any changes. This way any linter errors are easy to catch and fixable.

MehadND avatar Feb 12 '24 09:02 MehadND