memos icon indicating copy to clipboard operation
memos copied to clipboard

Published 20 hours ago • verified publisher icon usememos

feat: add visibility change dialog

Open moehanabi opened this issue 1 year ago • 2 comments

I am not familiar with ts/react coding, so please make a double check before merge.

Show visibility change dialog when sharing private memos, including workspace memos. In this dialog, user can change the visibility of the memo to public, so that the memo can be viewed by anyone with the link.

related issue: #2868

moehanabi avatar Feb 07 '24 05:02 moehanabi

Let's not make things too complicated. If the user want to change visibility, then he should edit the memo.

boojack avatar Feb 07 '24 09:02 boojack

Or we can show a visibility selector in memo sharing dialog.

image

boojack avatar Feb 07 '24 10:02 boojack

Or we can show a visibility selector in memo sharing dialog. image

I think it is a good idea. I will close the pr and open a new pr for it.

moehanabi avatar Feb 08 '24 17:02 moehanabi