memos icon indicating copy to clipboard operation
memos copied to clipboard

Published 20 hours ago • verified publisher icon usememos

Unable to double click to edit a memo

Open Arom1a opened this issue 1 year ago • 4 comments

Describe the bug

This is achievable in the previous version which is 0.18.1. This change is not mentioned in the release log so I doubt it is a bug rather than intended.

Steps to reproduce

  1. save a memo
  2. double click on it

The version of Memos you're using

0.18.2

Screenshots or additional context

No response

Arom1a avatar Jan 20 '24 10:01 Arom1a

@boojack kindly review this PR related to this issue.

MehadND avatar Jan 20 '24 14:01 MehadND

This issue is stale because it has been open 14 days with no activity.

github-actions[bot] avatar Feb 04 '24 00:02 github-actions[bot]

@MehadND why the PR was removed?

webysther avatar Feb 14 '24 21:02 webysther

@webysther I removed the PR because I either saw somewhere on GitHub or on Discord, where someone or maybe the project owner explained why the double click to edit memo functionality was removed. And at that time it seemed reasonable to remove the PR but if I can get the go from the project owner (@boojack) then I can re-open the PR.

p.s. found the reason, please check out this comment

MehadND avatar Feb 14 '24 22:02 MehadND

@MehadND Let's do not add double-click to edit, as it's inconsistent with a lot of behaviors and hard to select certain text anymore. We don't want to lose some functionality for convenience.

boojack avatar Feb 15 '24 01:02 boojack

@MehadND Let's do not add double-click to edit, as it's inconsistent with a lot of behaviors and hard to select certain text anymore. We don't want to lose some functionality for convenience.

Any chance in future add a button direct in header of a note with pen icon to edit?

webysther avatar Feb 15 '24 01:02 webysther

@MehadND Let's do not add double-click to edit, as it's inconsistent with a lot of behaviors and hard to select certain text anymore. We don't want to lose some functionality for convenience.

Any chance in future add a button direct in header of a note with pen icon to edit?

Well I think if you double click a memo header, it goes to that memo detail page and there you can edit the memo using pen icon. Maybe something you were looking for 🤷🏽‍♂️

MehadND avatar Feb 15 '24 01:02 MehadND

I agree with @webysther, a dedicated edit button on the note would be perfect if the double click is no longer an option.

rb-26 avatar Feb 15 '24 02:02 rb-26

@rb-26 each memo already has its dedicated edit button in the vertical action menu.

MehadND avatar Feb 15 '24 02:02 MehadND

@rb-26 each memo already has its dedicated edit button in the vertical action menu.

Yeah, but it is unnessesary clicks when you are editing notes often. Not a huge deal, just a nice to have.

rb-26 avatar Feb 15 '24 07:02 rb-26