memos icon indicating copy to clipboard operation
memos copied to clipboard

The height of operate dialog in "Create SSO" page is too big,would be better to reduce it

Open lucumt opened this issue 2 years ago • 11 comments

Is your feature request related to a problem?

After login into memos,click Settings -> SSO -> Create,it will show a dialog as below, the height is big thus the scroll bar appears,and it's very hard to read and input,we need to scroll the page image

Describe the solution you'd like

I think it would be better to has multiple columns in each row to display it ,so that we can not need to scroll the page and can view all form components.

Additional context

No response

lucumt avatar Aug 16 '23 05:08 lucumt

Great point! SSO is a feature under beta and ensuring its usability is more important. But at this stage, we don't have time to update the UI.

boojack avatar Sep 10 '23 04:09 boojack

@boojack So if someone make a PR for it,is it accessiable now?

lucumt avatar Sep 10 '23 10:09 lucumt

@lucumt Of course, maybe we can discuss your ideas first in this issue, such as the general UI.

boojack avatar Sep 12 '23 16:09 boojack

@boojack I had created a sample page at https://jsfiddle.net/gncz53wu/, you can check it further.

Below is the comparsion page to show the origin page and what I want to update for memos_create_sso_page

lucumt avatar Sep 13 '23 07:09 lucumt

@lucumt LGTM, and please keep an eye out for responsible styles in mobiles.

boojack avatar Sep 13 '23 07:09 boojack

@boojack It's memos support responsible styles in mobiles now?

lucumt avatar Sep 13 '23 07:09 lucumt

@lucumt

PC Mobile
image image

boojack avatar Sep 14 '23 08:09 boojack

Issue is not in English. It has been translated automatically.


@lucumt

PC Mobile
image image

Issues-translate-bot avatar Sep 14 '23 08:09 Issues-translate-bot

@boojack If anyone is not tackling this then please assign this to me. I would like to work on this.

MehadND avatar Jan 18 '24 14:01 MehadND

@boojack I made a PR related to this. Please take a look at it. Thanks

MehadND avatar Jan 19 '24 00:01 MehadND

This issue is stale because it has been open 14 days with no activity.

github-actions[bot] avatar Feb 06 '24 00:02 github-actions[bot]