memos icon indicating copy to clipboard operation
memos copied to clipboard

URLs with # data in them are treated as tags

Open buggithubs opened this issue 1 year ago • 3 comments

Describe the bug

https://github.com/usememos/memos/blob/3b1bab651a525faaf8baa0fb8cd0374ed7ef8305/server/tag_test.go#L37 This is a link that http://123123.com?123123#tag2 should not get #tag2 as a tag

Steps to reproduce

go to describe

Screenshots or additional context

No response

buggithubs avatar May 22 '23 10:05 buggithubs

also in code mode

save a password in this aera like 123456#123456

gitous avatar May 23 '23 04:05 gitous

We are implementing a markdown parser in go that will solve this problem effectively. Feel free to contribute code if you are interested! https://github.com/usememos/memos/tree/main/plugin/gomark

boojack avatar May 23 '23 13:05 boojack

We are implementing a markdown parser in go that will solve this problem effectively. Feel free to contribute code if you are interested! https://github.com/usememos/memos/tree/main/plugin/gomark

So is there a plan to migrate all the markdown parse from frontend to backend? PS: Why implementing markdown parser by yourself not using some 3rd library?

s0urcelab avatar Jun 08 '23 03:06 s0urcelab

Maybe fixed in the recent releases.

image

boojack avatar Sep 17 '23 02:09 boojack