jwt-auth icon indicating copy to clipboard operation
jwt-auth copied to clipboard

Oversight in dependency version for firebase/php-jwt

Open wavedeck opened this issue 7 months ago • 0 comments

According to composer.json, the dependency firebase/php-jwt is allowed to update implicitly until the last minor version of the current major (v6.x).

However, this would actually negate the mentioned minimum required PHP version (7.2) as described in the plugin README.

Starting with v6.5, php-jwt increased the minimum supported PHP version to 7.4 [email protected] on packagist

in the PR #112 , i noticed this and tried to mitigate it by only allowing patch releases within the current declared minor. This change was reverted in favor of discussing this beforehand.

Imho we have two different options, either, keep / update the current dependency version in composer.json and raise the minimum required PHP version of this plugin to 7.4 or lock the dependency version to patch-releases within v6.3 / v6.4

wavedeck avatar Jan 29 '24 15:01 wavedeck