easylauncher-gradle-plugin icon indicating copy to clipboard operation
easylauncher-gradle-plugin copied to clipboard

Generated icon no longer used when building with com.android.tools.build:gradle:7.3.0-rc01

Open litrik opened this issue 1 year ago • 16 comments

After upgrading com.android.tools.build:gradle from 7.3.0-beta05 to 7.3.0-rc01, the easylauncher icons are nog longer used. They are still being generated in the build/generated/easylauncher folder and Android Studio still renders them as the actual launcher icon, but after building and deploying the app, the undecorated base icon is shown.

I'd be surprised that this is a bug in Easylauncher, probably Google broke something in version 7.3.0-rc01 of the Android Build tools.

litrik avatar Sep 07 '22 07:09 litrik

Oh, thanks for letting me know! I only caught the plugin is completely broken on 7.4.0-alpha10 and reported it here: https://issuetracker.google.com/issues/244063664 It seems like AGP changed its behavior in 7.3.0 too, but it fails silently there. I'll investigate and post an update on the issuetracker

mateuszkwiecinski avatar Sep 07 '22 08:09 mateuszkwiecinski

Hello guys! Any update here? Android Studio Dolphin released with AGP 7.3.0 and generated icons are not used when building the app 😢

itolianezzz avatar Sep 16 '22 10:09 itolianezzz

same here AGP 7.3.0

miduch avatar Sep 18 '22 18:09 miduch

I just wonder - are adaptive icons affected or only mipmap versions?

emartynov avatar Sep 20 '22 08:09 emartynov

I have the same error with AGP 7.3.0

jumpbayern avatar Sep 28 '22 08:09 jumpbayern

Same anyone found workaround?

Jacks0N23 avatar Oct 04 '22 16:10 Jacks0N23

Please help with this issue

RustamSitdikov avatar Oct 10 '22 08:10 RustamSitdikov

Hi, @mateuszkwiecinski any news on this issue ? Or any functional workaround/alternatives ?

huextrat avatar Oct 11 '22 07:10 huextrat

I can confirm that upgrading to com.android.tools.build:gradle:7.4.0-beta02 and setting android.disableResourceValidation=true in gradle.properties does solve/workaround the issue.

litrik avatar Oct 11 '22 08:10 litrik

But unfortunatelly it doesn't seems to work with 7.3.0

NitroG42 avatar Oct 11 '22 11:10 NitroG42

I can't confirm the workaround. The badge is still not showing up for me. I tried as well with com.android.tools.build:gradle:7.4.0-beta02 android.disableResourceValidation=true and AndroidStudio Electric Eel to make the gradle version 7.4.0 work. @litrik is there anything else you changed?

ba-a avatar Oct 11 '22 14:10 ba-a

I can't confirm the workaround. The badge is still not showing up for me. I tried as well with com.android.tools.build:gradle:7.4.0-beta02 android.disableResourceValidation=true and AndroidStudio Electric Eel to make the gradle version 7.4.0 work. @litrik is there anything else you changed?

Those were indeed the only changes I did to get it working with 7.4.0-beta02 (in Electric Eel and after a good Gradle sync, clean and rebuild of the project).

litrik avatar Oct 11 '22 15:10 litrik

I have the same issue as reported above. Sticking to 7.2.2 for a little while longer until hopefully the issue is resolved somehow.

casperbang avatar Oct 13 '22 05:10 casperbang

Hi mateuszkwiecinski

any plan on fixing this issue??

HashirLabs avatar Oct 13 '22 10:10 HashirLabs

same same; AGP 7.3.0, easyLauncher 5.1.2

poorpeschino avatar Oct 13 '22 12:10 poorpeschino

@HashirLabs @poorpeschino, please read the whole thread. There is a reason for the issue and a couple of proposed solutions. Particullary, https://github.com/usefulness/easylauncher-gradle-plugin/issues/349#issuecomment-1239054798, https://github.com/usefulness/easylauncher-gradle-plugin/issues/349#issuecomment-1274275555 and https://github.com/usefulness/easylauncher-gradle-plugin/issues/349#issuecomment-1277068235.

emartynov avatar Oct 13 '22 15:10 emartynov

I'll share an update: I just released v6.0.0 which helps to work around the issue (thanks to the great contribution of @kkris). It's possible 6.0.0 will work out of the box for you, but if you start observing a "Error: Duplicate resources." error, you can follow the workaround mentioned on AGP issue page and add android.disableResourceValidation=true to gradle.properties. This should make the plugin work again 🎉 If my observations are correct, AGP starting from 8.0 won't need the android.disableResourceValidation=true workaround.

mateuszkwiecinski avatar Nov 12 '22 10:11 mateuszkwiecinski

We have the icons in a theme module. That module also includes the easylauncher plugin. After upgrading, we no longer are seeing the generated icon. We can see it in the build folder but the application module is not able to reference it. I looked at samples to see if we are missing something.

Based on https://github.com/usefulness/easylauncher-gradle-plugin/blob/master/sample/gradle.properties, we added the following to our project. Unfortunately it also made no difference.

android.disableResourceValidation=true
android.nonTransitiveRClass=true

keith30xi avatar Nov 15 '22 12:11 keith30xi

I am using AGP 7.4.1 and easy launcher 6.1.0. But still generated icons are not being used at the time of deployment. Issue still exist. Can we reopen this issue.

rizwan-dev avatar Feb 09 '23 17:02 rizwan-dev

#349 (comment)

This workaround is not showing banner for me

rizwan-dev avatar Feb 09 '23 17:02 rizwan-dev