picow_ds4 icon indicating copy to clipboard operation
picow_ds4 copied to clipboard

Missing files from btstack

Open ux-lic opened this issue 2 years ago • 9 comments

When I try to compile this code with cmake I get this error saying it cannot find avrcp_coverart_client.c

Any idea why it is looking for this file?

-- Configuring done (0.3s) CMake Error at src/CMakeLists.txt:13 (target_link_libraries): Cannot find source file:

/Users/dosho0/Github/picow_ds4/btstack/src/classic/avrcp_cover_art_client.c

Tried extensions .c .C .c++ .cc .cpp .cxx .cu .mpp .m .M .mm .ixx .cppm .ccm .cxxm .c++m .h .hh .h++ .hm .hpp .hxx .in .txx .f .F .for .f77 .f90 .f95 .f03 .hip .ispc

ux-lic avatar Oct 12 '23 22:10 ux-lic

Hi, that's strange.

Could you tell me what you've run to get to this point? I just tried a clean check-out and it's fine. The version of btstack that's pinned in the submodule does indeed not appear to have that file, but that doesn't cause me any issues, and I can't see any references to it in (that version) of the code.

Did you change the version of btstack?

The avrcp files which build for me are:

[ 52%] Building C object src/CMakeFiles/picow_ds4.dir/__/btstack/src/classic/avrcp.c.obj                                                                                                                                                                                    
[ 52%] Building C object src/CMakeFiles/picow_ds4.dir/__/btstack/src/classic/avrcp_browsing.c.obj                                                                                                                                                                           
[ 53%] Building C object src/CMakeFiles/picow_ds4.dir/__/btstack/src/classic/avrcp_browsing_controller.c.obj                                                                                                                                                                
[ 53%] Building C object src/CMakeFiles/picow_ds4.dir/__/btstack/src/classic/avrcp_browsing_target.c.obj                                                                                                                                                                    
[ 54%] Building C object src/CMakeFiles/picow_ds4.dir/__/btstack/src/classic/avrcp_controller.c.obj                                                                                                                                                                         
[ 54%] Building C object src/CMakeFiles/picow_ds4.dir/__/btstack/src/classic/avrcp_media_item_iterator.c.obj                                                                                                                                                                
[ 55%] Building C object src/CMakeFiles/picow_ds4.dir/__/btstack/src/classic/avrcp_target.c.obj

usedbytes avatar Oct 13 '23 19:10 usedbytes

I am getting the same error ux-lic is seeing.

briangavin avatar Nov 20 '23 20:11 briangavin

OK I've reproduced and found the issue - see the issue I opened on pico-sdk above.

Basically I need to update my version of btstack to work with newer pico-sdk versions - but that means it will break for older pico-sdk versions. Which is annoying.

I've pushed an update to main which will hopefully fix your issues.

usedbytes avatar Nov 20 '23 21:11 usedbytes

I was running into the same error, so I followed the breadcrumbs, but still ran into issues. I tried running git submodule update --init --recursive but I received an error saying:

Submodule 'btstack' (https://github.com/usedbytes/btstack) registered for path 'btstack'
Cloning into '/home/fank/Documents/pico/projects_bt/picow_ds4/btstack'...
fatal: remote error: upload-pack: not our ref 2382b034608370bf1dea2e7d59adba4deb8f9047
fatal: Fetched in submodule path 'btstack', but it did not contain 2382b034608370bf1dea2e7d59adba4deb8f9047. Direct fetching of that commit failed.
fatal: 

I tried using the hid_ds4 branch (and master) branch off your btstack fork, but no luck. Anyway I get the correct btstack version? I'd also like to note I rolled back my SDK to the correct hash listed in the readme. This repo would save my project! Any help would be appreciated. Thanks.

FrankLaterza avatar Dec 16 '23 01:12 FrankLaterza

I've hit the same problem as Frank. It gives the error for both the master and rolled back versions of the pico_sdk.

edrobertsrayne avatar Dec 17 '23 14:12 edrobertsrayne

Hi - could you please try again? Looks like I might have not pushed the updated btstack commit to my fork. I think I've fixed it now.

usedbytes avatar Dec 17 '23 17:12 usedbytes

This worked for me thanks!

FrankLaterza avatar Dec 17 '23 21:12 FrankLaterza

Also worked fine for me. Thanks.

On Sun, 17 Dec 2023 at 21:07, fank @.***> wrote:

This worked for me thanks!

— Reply to this email directly, view it on GitHub https://github.com/usedbytes/picow_ds4/issues/1#issuecomment-1859284630, or unsubscribe https://github.com/notifications/unsubscribe-auth/AXC2NCEV2TE4KZNONB5GZUTYJ5NIVAVCNFSM6AAAAAA56JIL7KVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNJZGI4DINRTGA . You are receiving this because you are subscribed to this thread.Message ID: @.***>

edrobertsrayne avatar Dec 17 '23 21:12 edrobertsrayne

Works now thanks!

ux-lic avatar Mar 25 '24 02:03 ux-lic