bruno icon indicating copy to clipboard operation
bruno copied to clipboard

CLI 2 critical severity vulnerabilities

Open bourpie opened this issue 2 years ago • 9 comments
trafficstars

When installing CLI on Node V. 18.14.1, I get this message

npm WARN deprecated [email protected]: The library contains critical security issues and should not be used for production! The maintenance of the project has been discontinued. Consider 
migrating your code to isolated-vm.

changed 146 packages, and audited 147 packages in 11s

34 packages are looking for funding
  run `npm fund` for details

2 critical severity vulnerabilities

bourpie avatar Nov 08 '23 13:11 bourpie

vm2 has been deprecated for a while now, and we already planned to update to a different library here #263.

The vulnerabilities in vm2 allow for malicious code to escape the sandbox. I think if you only run trusted request scripts it should be fine for now, but we will definitely address this in the future.

Its-treason avatar Nov 08 '23 16:11 Its-treason

I would say that this should be fairly high priority if you're looking to drive adoption. I'm evaluating Bruno to use at my workplace and things like that will definitely raise eyebrows. I wanted to test the cli but immediately uninstalled it when confronted by those security warnings.

chriswarkentin avatar Jan 12 '24 19:01 chriswarkentin

Is there any progress on this? I love Bruno, but unfortunately cannot use the CLI until this is addressed and thus cannot use it to automate API testing

camba1 avatar Mar 27 '24 22:03 camba1

Is there any progress on this? I love Bruno, but unfortunately cannot use the CLI until this is addressed and thus cannot use it to automate API testing

Not really, I opened a second PR that replaced vm2 with the native vm module. But this did not get any attention yet.

Its-treason avatar Mar 28 '24 01:03 Its-treason