bruno icon indicating copy to clipboard operation
bruno copied to clipboard

insomnia-importer: import environments

Open petoc opened this issue 2 years ago • 9 comments

Import environments.

petoc avatar Oct 06 '23 09:10 petoc

@petoc

Thank you for the PR!

Just a quick question, Have we taken care of converting insomnias nested variables and replace . with _

As in auth.token -> auth_token The expected behaviour is that env vars should follow javascript's variable naming validation which is

Variable Names Must Start with a Letter, Underscore (_), or Dollar Sign ($)

Also See https://github.com/usebruno/bruno/issues/345

helloanoop avatar Oct 06 '23 18:10 helloanoop

Sorry about that I was not aware of that, thanks for pointing that out. Updated PR to address this.

  • environment variables (objects/arrays) should be flattened
  • variables in body/query/auth/headers are normalized too

I suppose there will be some issues with variables due to nested environments in Insomina (i.e. one variable from Base Environment and other from Sub Environment in one request), but it should be resolved in Bruno v2 (#292).

petoc avatar Oct 09 '23 06:10 petoc

@helloanoop if there is anything else you would like to address, please let me know.

I noticed that there is already issue #472 which should be solved by this PR.

petoc avatar Oct 11 '23 01:10 petoc

LGTM 🎉

F0rce avatar Oct 17 '23 11:10 F0rce

This would be amazing to have as it is a blocker for converting from Insomnia for us.

halostatue avatar Dec 04 '23 16:12 halostatue

@petoc Could you please resolve the conflicts on this branch? I am looking forward to this being merged 😊.

ItsJustRuby avatar Mar 10 '24 11:03 ItsJustRuby

Updated, but it is up to @helloanoop if it will be merged.

petoc avatar Apr 10 '24 05:04 petoc

any updates here?

szechyjs avatar Apr 22 '24 17:04 szechyjs

@petoc / @helloanoop Also very much looking forward to this feature! Let me know if I can help at all. Happy to resolve conflicts, etc.

atomdmac avatar May 17 '24 15:05 atomdmac