insomnia-importer: import environments
Import environments.
@petoc
Thank you for the PR!
Just a quick question, Have we taken care of converting insomnias nested variables and replace . with _
As in auth.token -> auth_token
The expected behaviour is that env vars should follow javascript's variable naming validation which is
Variable Names Must Start with a Letter, Underscore (_), or Dollar Sign ($)
Also See https://github.com/usebruno/bruno/issues/345
Sorry about that I was not aware of that, thanks for pointing that out. Updated PR to address this.
- environment variables (objects/arrays) should be flattened
- variables in body/query/auth/headers are normalized too
I suppose there will be some issues with variables due to nested environments in Insomina (i.e. one variable from Base Environment and other from Sub Environment in one request), but it should be resolved in Bruno v2 (#292).
@helloanoop if there is anything else you would like to address, please let me know.
I noticed that there is already issue #472 which should be solved by this PR.
LGTM 🎉
This would be amazing to have as it is a blocker for converting from Insomnia for us.
@petoc Could you please resolve the conflicts on this branch? I am looking forward to this being merged 😊.
Updated, but it is up to @helloanoop if it will be merged.
any updates here?
@petoc / @helloanoop Also very much looking forward to this feature! Let me know if I can help at all. Happy to resolve conflicts, etc.