feat: save-all command
Description
While using Bruno, I always wondered why the save-all feature did not exist.
I read the issues and realized that it had been addressed multiple times: #737, #846, #2916, and PR #890. However, for some reason, the PR was not merged.
I did my best to use existing functions and only added or changed code when necessary.
I mainly used the already implemented function saveMultipleRequests to handle the save-all command and needed to add saveSilently because I had to add a toast (referencing the existing saveRequest function).
Contribution Checklist:
- [x] The pull request only addresses one issue or adds one feature.
- [x] The pull request does not introduce any breaking changes
- [x] I have added screenshots or gifs to help explain the change if applicable.
- [x] I have read the contribution guidelines.
- [x] Create an issue and link to the pull request.
Note: Keeping the PR small and focused helps make it easier to review and merge. If you have multiple changes you want to make, please consider submitting them as separate pull requests.
Publishing to New Package Managers
Please see here for more information.
LGTM
Hi @junglesub, thanks for your contribution! We'd love to get this PR merged. I've requested a few changes, could you please take a look and address them when you have a chance? Thanks!
Hi @junglesub, thanks for your contribution! We'd love to get this PR merged. I've requested a few changes, could you please take a look and address them when you have a chance? Thanks!
Thanks for your review! I will work on it!
Sorry for the silly mistake! I made adjustment thanks :)
Hi! I realized that "save-all" doesn't work when the textbox is active. I will take a look
I had to add the saveAll listener to all CodeMirror modules.
This caused some merge conflicts, which I’ve resolved to the best of my ability. I’ve tested the changes and everything seems to be working fine.
Kindly take a look and let me know if you spot anything I might’ve missed. 🙏
Hi @junglesub, thanks for your work on this! I noticed that after the latest set of changes, this PR has grown quite large with 33 files changed. This makes it quite challenging for our team to review and merge efficiently.
We understand why those changes were necessary, especially to address the issue of not saving when a textbox is active. However, we believe there might be a more optimized solution—perhaps by bubbling up the event or using a different approach that avoids touching so many components.
Could you take another look and see if there's a way to simplify the implementation? We'll also do some exploration on our side and share any better alternatives we come up with.
Thanks again!