bruno icon indicating copy to clipboard operation
bruno copied to clipboard

feat: add support for state param for OAuth2 Authorization Code flow

Open dhananjaykadam opened this issue 1 year ago • 2 comments

Issue Reference

https://github.com/usebruno/bruno/issues/2275

Description

Adding support for state param which is expected on OAuth2 authorization code flow

  • There is also another PR trying to solve same issue but generating state param on the fly, but that is still not merged, so created this in case this is expected, any of two can be merged and other closed.
  • This PR should save the state and reload as well and can allow user to pass whatever state they wants to

image

Contribution Checklist:

  • [x] The pull request only addresses one issue or adds one feature.
  • [x] The pull request does not introduce any breaking changes
  • [x] I have added screenshots or gifs to help explain the change if applicable.
  • [x] I have read the contribution guidelines.
  • [x] Create an issue and link to the pull request.

Note: Keeping the PR small and focused helps make it easier to review and merge. If you have multiple changes you want to make, please consider submitting them as separate pull requests.

Publishing to New Package Managers

Please see here for more information.

dhananjaykadam avatar May 17 '24 09:05 dhananjaykadam

Github issue: https://github.com/usebruno/bruno/issues/2275

dhananjaykadam avatar May 17 '24 09:05 dhananjaykadam

@lohxt1 Assigning this to you

Lets make it a priority to have this merged early next week.

helloanoop avatar May 22 '24 20:05 helloanoop

Fixed reviews! Feel free to take a look

dhananjaykadam avatar May 24 '24 15:05 dhananjaykadam

Let me know if any more changes are needed to this PR @lohxt1

dhananjaykadam avatar May 31 '24 05:05 dhananjaykadam

Merged!

Thanks @dhananjaykadam for working on this! Thanks @pietrygamat @lohxt1 for the review.

This will go out next Tuesday, June 4th 2024.

helloanoop avatar May 31 '24 10:05 helloanoop