bruno icon indicating copy to clipboard operation
bruno copied to clipboard

interpolate vars correctly in graphql introspection request

Open Jackevansevo opened this issue 9 months ago • 1 comments

Description

It looks like there was regression with the graphql introspection query code that was preventing pre-request scripts from settings header values in the prepared request.

https://github.com/usebruno/bruno/issues/704

Using an example here, a pre-script that sets some authentication headers

Screenshot 2024-05-15 at 17 20 59

This data now actually gets sent through to the backend

X-Mul-Nonce: xxxx
X-Mul-Timestamp: xxxx
X-Mul-Signature: xxxxx

So my (previously broken) introspection request now succeeds.

Screenshot 2024-05-15 at 17 21 14

Contribution Checklist:

  • [x] The pull request only addresses one issue or adds one feature.
  • [x] The pull request does not introduce any breaking changes
  • [x] I have added screenshots or gifs to help explain the change if applicable.
  • [x] I have read the contribution guidelines.
  • [x] Create an issue and link to the pull request.

Note: Keeping the PR small and focused helps make it easier to review and merge. If you have multiple changes you want to make, please consider submitting them as separate pull requests.

Publishing to New Package Managers

Please see here for more information.

Jackevansevo avatar May 15 '24 16:05 Jackevansevo

@lohxt1 Can you review this?

helloanoop avatar May 22 '24 13:05 helloanoop

Merged!

Thanks for working on this @Jackevansevo ! Thanks for the review @lohxt1 !

helloanoop avatar Jun 19 '24 10:06 helloanoop