previous value of variable used in JSON body

[applepies]

I have checked the following:

• [X] I use the newest version of bruno.
• [X] I've searched existing issues and found nothing related to my issue.

Describe the bug

When using variables inside a JSON body, upon executing the request, the body sent contains the previous value of the variable

Repro:

1. create a new request, POST, https://www.example.com
2. set the body to JSON and add { "foo": "{{bar}}" } as the body
3. add a variable bar with value 123
4. send the request
5. observe > data {"foo":"123"} in the Timeline
6. update the value of bar to 1234
7. send the request again
8. observe > data {"foo":"123"} in the Timeline
9. send the request a third time
10. observe > data {"foo":"1234"} in the Timeline

.bru file to reproduce the bug

example.zip

Screenshots/Live demo link

[frille700]

I have seen seen similar problem, when trying to set the env variable that is used in the body, with a pre-request script. It appears that the pre request script is NOT preceeding the body construction. The pre request script should preceed everything in the request, even the construction of the request itself, including body and headers etc. Otherwise the full potential of the pre request script is not there

[marfranke]

@frille700 I get your point. But executing the pre-request script directly before the execution of the request has the advantage, that you can work with the fully prepared request. So maybe splitting the pre-request script in two (pre-prepare-request and pre-request) is better to get the best of both worlds.

[marfranke]

And it relates to https://github.com/usebruno/bruno/issues/2249. However, this issue describes the opposite...

[frille700]

Yes I have realized the advantages with the pre request too. I got it to work by using the req.setBody in the pre request script and that way was able to set what I wanted. But, as you point out, it would be neat with a pre-prepare-request kind of thing

[VeselovAndrey]

Similar issue with variables in the URL segment. E.g. {{serverRoot}/content/{{id}} After {{id}} change next request will use old {{id}} value and only 2nd attempt will use new value.

[applepies]

I got it to work by using the req.setBody in the pre request script and that way was able to set what I wanted.

thanks @frille700 - this is a workaround I can work with

[lewg]

Similar issue with variables in the URL segment. E.g. {{serverRoot}/content/{{id}} After {{id}} change next request will use old {{id}} value and only 2nd attempt will use new value.

This, in particular, has broken all my collections. Is the intention to remove that capability entirely? If not, how would you set those before the request now?

[fburato]

@VeselovAndrey: I'm getting the same issue. Downgrading to version v1.14.0 appears to fix it.

[luisdosreis]

Similar issue with variables in the URL segment. E.g. {{serverRoot}/content/{{id}} After {{id}} change next request will use old {{id}} value and only 2nd attempt will use new value.

This, in particular, has broken all my collections. Is the intention to remove that capability entirely? If not, how would you set those before the request now?

This can be dangerous if you are doing operations in a production environment. Needs to be fixed or users warned.

[lohxt1]

@applepies @frille700 @VeselovAndrey @lewg @fburato @marfranke @luisdosreis

This issue has been fixed in v1.18.0.

Could you please verify and let me know if you're still facing any issues?

[VeselovAndrey]

@lohxt1 Did a quick test with 1 request and 2 different values in a URL segment - see no issues.

[luisdosreis]

Can confirm that it seems fixed in v1.18.0.

[lohxt1]

closing

please re-open if you are still facing the issue