bruno
bruno copied to clipboard
usebruno
feature: response panel split horizontal
Description
Resolves: #1041
With this change:
- it is now possible to split the request/response panels vertically or horizontally
- vertical overflows have been adjusted in all screens in both horizontal and vertical layouts
- the split direction is persisted as a user preference
- it is now more comfortable to work with Bruno and an IDE open at the same time on the same screen
Here is the demo:
https://github.com/usebruno/bruno/assets/139650490/86b6c4db-84f7-46c0-8f50-388054e9a537
And more screenshots:
Contribution Checklist:
- [X] The pull request only addresses one issue or adds one feature.
- [X] The pull request does not introduce any breaking changes
- [X] I have added screenshots or gifs to help explain the change if applicable.
- [X] I have read the contribution guidelines.
- [X] Create an issue and link to the pull request.
Note: Keeping the PR small and focused helps make it easier to review and merge. If you have multiple changes you want to make, please consider submitting them as separate pull requests.
Publishing to New Package Managers
Please see here for more information.
Hey small thing, instead of opening a new PR every time you squash your commits, you can just rebase your branch and then force push. This way you don't have to open & close your PR's.
Hey small thing, instead of opening a new PR every time you squash your commits, you can just rebase your branch and then force push. This way you don't have to open & close your PR's.
Ok sorry about that, I will do like you suggest next times
Sorry for making more changes to my PR recently, but I am now happy with my changes, I am confident it works because I went through all screens to verify the display. So I am done, I am not making anymore changes.
Hi @sanjai0py, would you be able by any chance to assign the PR to someone for review ? Cheers
Hi @Its-treason Would you have the chance to review this PR, currently it's not assigned to anyone
I can review your PR in the next few days. But your PR is quite big, so it will take some time to review.
But before I start reviewing this, I would like for @helloanoop to confirm that: We want this, and it gets merged soon after reviewing.
Just to explain why this change is pretty important for me and certainly others.
If you put side by side your ide and bruno, you have very narrow columns for request and response in bruno, see below my screen
And lucky me, I have a pretty wide screen...
@busy-panda This is something that we definetely want to get merged.
One of the concerns I have merging a large PR like this is that it would also need extensive testing before we ship the build as we do not want to break the interface for the current vertical split (like the code editor heights)
Also, there is a large number of other PR's that rank higher in priority. I will come back to this in about 1-2 weeks. Thanks for your patience.
Hi @helloanoop I fixed the conflicts and retested. Could we please have this PR merged ?
Hi @helloanoop I fixed the conflicts and retested. Could we please have this PR merged ?
I second this being merged in, this is a great feature.
Thanks for taking the time to work on this @end3rbyte !
The PR is quite huge, and the code has also undergone significant changes. We have also removed a lot of hardcoding the heights of the code editors (codemirror), than should make the implementation of this a lot more easier.
I feel this functionality is better implemented by someone here internally at Bruno Core Team. We'll keep this PR open as a reference PR. In terms of an ETA, we are looking at end of Sep to have this feature released.
Hi @helloanoop This is a bit a shame because this is a pretty basic feature and I doubt your team will be able to implement it with less changes. I've sync and fixed the conflicts, I had to revert what was implemented recently on query params (https://github.com/usebruno/bruno/pull/2641) because what was implemented with absolute position is not compatible with a horizontal screen split. Demo recorded today with latest code:
https://github.com/user-attachments/assets/32f4b5d2-ee5f-4a52-b302-75aaacdf9f21
I really hope for this feature to be implemented as well. Just came to look if it's already in the tracker.
It's not just for people having two windows side by side - I have my "documentation" screen in portrait mode, so the Response panel I'm looking at is really small.
