bruno icon indicating copy to clipboard operation
bruno copied to clipboard

feature: Multi-part requests: user should be able to set content-type for each part in a multi-part request. #1602

Open end3rbyte opened this issue 10 months ago • 16 comments

Multi-part requests: user should be able to set content-type for each part in a multi-part request (Issues: #1602)

Fixes https://github.com/usebruno/bruno/issues/1602

Description

An optional column "Content-Type" was added.

image

Example how the content type is saved in the .bru file:

image

multi-body

Demo:

https://github.com/usebruno/bruno/assets/139650490/f0132226-baae-4eb7-8587-777273c3699e

Contribution Checklist:

  • [X] The pull request only addresses one issue or adds one feature.
  • [X] The pull request does not introduce any breaking changes
  • [X] I have added screenshots or gifs to help explain the change if applicable.
  • [X] I have read the contribution guidelines.
  • [X] Create an issue and link to the pull request.

Note: Keeping the PR small and focused helps make it easier to review and merge. If you have multiple changes you want to make, please consider submitting them as separate pull requests.

Publishing to New Package Managers

Please see here for more information.

end3rbyte avatar Apr 18 '24 13:04 end3rbyte

Ready for Review

end3rbyte avatar Apr 18 '24 13:04 end3rbyte

The CI is failing because I have added a new endpoint to the CLI backend, end the CI run against the current prod backend which has not yet the endpoint I added image Can we continue the workflow to merge the PR ?

end3rbyte avatar Apr 25 '24 12:04 end3rbyte

Hi @Its-treason Would it be possible to review this PR please ? It's assigned to you. The issue fixed by this PR is pretty annoying with java backends because json needs to have the proper content type or it fails. Thanks

end3rbyte avatar May 01 '24 07:05 end3rbyte

Hello, will be there a possibility to upload a file as application/octet-stream (as an entire request), not like multipart-form data?

E.g. as Postman has: image

MrFishchev avatar May 02 '24 10:05 MrFishchev

No, but it makes sens, so i suggest you to create an enhancement ticket for it, if there is no ticket already.

It should be added in this list

image

With a file selector to select the file to upload

end3rbyte avatar May 02 '24 11:05 end3rbyte

excited for this feature... it's almost a blocker for us in our abandonment of Postman.

timothystone-knsl avatar May 20 '24 15:05 timothystone-knsl

The tests are failing but they will pass as soon as this PR is merged. It is because I added a new route in the CLI test backend: https://github.com/usebruno/bruno/pull/2121/files#diff-28dd2fe431464ec2945e9ca3470f5ae58a0be3b7c46b65980625150314b2988b

image

end3rbyte avatar Jul 01 '24 14:07 end3rbyte

Hi @helloanoop I fixed the conflicts and retested. Could we please have this PR merged ?

end3rbyte avatar Jul 01 '24 14:07 end3rbyte

Looking forward to this feature being merged - thanks for working on this @end3rbyte !

danishmughal avatar Jul 23 '24 21:07 danishmughal

@end3rbyte Hi, I'm waiting for this feature, can I know when it will be reflected?

lee-dongyeop avatar Aug 06 '24 05:08 lee-dongyeop

🙏 @end3rbyte do the conflicts need to be resolved before the merge can happen?

timothystone-knsl avatar Aug 22 '24 17:08 timothystone-knsl

This feature and also sending raw files as a request, are our only holdbacks from switching to bruno, hopefully we can have these on main asap <3 @helloanoop

tktsour avatar Aug 23 '24 06:08 tktsour

Thank you all for your patience. The PR looks good overall. We are currently reviewing it and will provide an update in the next few days.

helloanoop avatar Sep 02 '24 10:09 helloanoop

I've sync and fixed the conflict

end3rbyte avatar Sep 10 '24 08:09 end3rbyte

@end3rbyte @helloanoop The confict is said to have been fixed, so please merge. I'm waiting for the feature. Thank you. <3

lee-dongyeop avatar Sep 10 '24 08:09 lee-dongyeop

It's been 3+ weeks since the "merged in next few days". This feature is great and needed, any info on this?

vkopanja avatar Sep 26 '24 10:09 vkopanja