bruno icon indicating copy to clipboard operation
bruno copied to clipboard

fix(#352): Variable interpolation for multipart form body

Open Its-treason opened this issue 1 year ago • 17 comments

  • Moved creation of FormData object into interpolation phase
  • BREAKING CHANGE: This means in the pre-request-script req.body is no longer the FormData object, instead it's a plain key value object (See Input Body in the second screenshot).

Closes: #352


App: grafik

Cli: grafik

Its-treason avatar Dec 13 '23 21:12 Its-treason

How's it going?

ARESBAN avatar Jan 29 '24 01:01 ARESBAN

Any progress on that ? Could be nice to have :)

blured75 avatar Jan 31 '24 08:01 blured75

Hello. I'm interested in this fix. Any idea when it will be merged?

@helloanoop, it would be awesome to have this in the codebase - the bug is super annoying.

Andreas-Schoenefeldt avatar Feb 07 '24 15:02 Andreas-Schoenefeldt

I fixed the Merge conflicts. I'm not sure about the changes to all the README's i think those are made by prettier.

Its-treason avatar Feb 07 '24 18:02 Its-treason

Is there any progress on that? Can I help in any manner? It blocks us from moving from Insomnia to Bruno :S

mariomka avatar Feb 22 '24 07:02 mariomka

Hi @mariomka, it is usually best to contact @helloanoop in Discord.

Andreas-Schoenefeldt avatar Feb 23 '24 05:02 Andreas-Schoenefeldt

Any updates?

xosealvarez avatar Mar 07 '24 10:03 xosealvarez

Any updates?

Not yet, I also need to fix merge conflicts, when this is allowed to be merged.

For now, you can download my fork, that includes this and some other merge requests, but is still 100 percent compatible with normal bruno: https://github.com/Its-treason/bruno/releases/tag/nightly

Its-treason avatar Mar 07 '24 10:03 Its-treason

Hi @Its-treason, your fork works really good, well done, thanks a lot

xosealvarez avatar Mar 07 '24 10:03 xosealvarez

Any updates? :) Still waiting on this before I can fully switch to Bruno!

Schoof-T avatar Mar 27 '24 10:03 Schoof-T

This is a problem for us also. I suppose we could disable the 20 or so tests for now that require this with our project but definitely a pain point.

chriswinter90 avatar Apr 16 '24 14:04 chriswinter90

We are also waiting for this fix

mleziva avatar May 06 '24 16:05 mleziva

I think it is already good in the latest version of Bruno - it might have been fixed by some other ticket. At least my collections are not running, but I had to enter the variables fresh after update.

Andreas-Schoenefeldt avatar May 06 '24 20:05 Andreas-Schoenefeldt

I think it is already good in the latest version of Bruno - it might have been fixed by some other ticket. At least my collections are not running, but I had to enter the variables fresh after update.

I tried this with the latest version and the issue continues, It's not solved yet. (Version 1.16.1)

xosealvarez avatar May 08 '24 13:05 xosealvarez

@helloanoop This PR definitely needs to be merged, many people are waiting on it. Could we please move forward with it ?

end3rbyte avatar May 15 '24 06:05 end3rbyte

I did another ping on this topic in the Discord Bugs Channel - It is at least on the radar again 🤞.

Andreas-Schoenefeldt avatar May 15 '24 09:05 Andreas-Schoenefeldt