bruno icon indicating copy to clipboard operation
bruno copied to clipboard
verified publisher icon usebruno

White screen while trying to delete a request or folder when folder/collection run tab is open

Open andrii-lemdianov opened this issue 2 years ago • 1 comments

Hi, I'm facing the issue - White screen - while trying to delete a request or folder when folder/collection run tab is open

Steps to Reproduce

  1. Open or import any collection (e.g. https://github.com/usebruno/github-rest-api-collection)
  2. Clone a single request or a folder
  3. Run a new folder or modified one
  4. Attempt to remove a folder or a single request

Expected Behavior

  • A folder or a single request successfully removed

Actual Behavior

  • White screen appeared and the only way to continue work - restart Bruno
  • The following error is shown in the DevTool console {error: TypeError: Cannot read properties of undefined (reading 'name') at file:///Applications/Bruno%2…, errorInfo: {…}} error : TypeError: Cannot read properties of undefined (reading 'name') at file:///Applications/Bruno%202.app/Contents/Resources/app.asar/web/_next/static/chunks/735-b84c189edc58c0d8.js:1:134919 at Ot (file:///Applications/Bruno%202.app/Contents/Resources/app.asar/web/_next/static/chunks/pages/_app-f501db2fe71d320a.js:1:332867) at wa (file:///Applications/Bruno%202.app/Contents/Resources/app.asar/web/_next/static/chunks/pages/_app-f501db2fe71d320a.js:1:369199) at mr (file:///Applications/Bruno%202.app/Contents/Resources/app.asar/web/_next/static/chunks/735-b84c189edc58c0d8.js:1:134867) at Eo (file:///Applications/Bruno%202.app/Contents/Resources/app.asar/web/_next/static/chunks/framework-49f1e091cbf6b261.js:1:63194) at Pu (file:///Applications/Bruno%202.app/Contents/Resources/app.asar/web/_next/static/chunks/framework-49f1e091cbf6b261.js:1:74882) at xi (file:///Applications/Bruno%202.app/Contents/Resources/app.asar/web/_next/static/chunks/framework-49f1e091cbf6b261.js:1:121317) at bs (file:///Applications/Bruno%202.app/Contents/Resources/app.asar/web/_next/static/chunks/framework-49f1e091cbf6b261.js:1:109370) at gs (file:///Applications/Bruno%202.app/Contents/Resources/app.asar/web/_next/static/chunks/framework-49f1e091cbf6b261.js:1:109298) at vs (file:///Applications/Bruno%202.app/Contents/Resources/app.asar/web/_next/static/chunks/framework-49f1e091cbf6b261.js:1:109161) errorInfo : {componentStack: '\n at mr (file:///Applications/Bruno%202.app/Con…t/static/chunks/main-ad5649da2d8f61d3.js:1:11344)'} [[Prototype]] : Object

Additional Information

OS: macOS Monterey, App: Latest Version: 1.4.0, Mac Apple Silicon Release Date: Dec 5, 2023 Electron: 21.1.1 Chrome: 106.0.5249.103 node: 16.16.0 v8: 10.6.194.17-electron image I made a short screen recording

https://github.com/usebruno/bruno/assets/60614852/a8e17a78-797c-4004-b8b5-b38cb46061c7

andrii-lemdianov avatar Dec 12 '23 11:12 andrii-lemdianov

patch.txt

untested but should work. Dispatcher "unlockmouse"

vaxerski avatar Mar 03 '24 19:03 vaxerski

Thank you for this, I tried configuring it two different ways which seemed to be accepted:

bindm = SUPER, , unlockmouse
bindr = SUPER, , unlockmouse

But I found a few issues:

  • Unsure if its a bug with this or not, but my house hides by itself periodically?
  • Mouse is still hidden by the program (tested with helldivers because everyone is playing that atm)
  • It does allow for things like resizing the window but the behaviour is buggy as the mouse is being teleported around a bit
  • Mouse doesn't seem constrained by program, but upon releasing the mouse it gets stolen again, maybe because we aren't recalculating what program the mouse should activate? Or maybe we never even properly deactivated the program to begin with (borders indicate the program was never deactivated?)

At least with nix its easy for me to compile and run the thing so i might look into this myself but the solution is most definitely not obvious to me

Ashe avatar Mar 05 '24 20:03 Ashe

hm, I think a variable here would work better, to be honest. Have a binding to toggle it to ignore constraints altogether, thoguths?

vaxerski avatar Mar 05 '24 20:03 vaxerski

Thank you for the nudge and I appreciate you're trying to get more people contributing. If I get time I'll have a look and see if I can make sense of your advice but I just don't know the architecture of hyprland really.

I think for my personal usecase I'd want it to be a hold button - I'd want to hold my super key so that when I'm doing my normal hyprland usage and dragging windows around my mouse is always available and unimpeded. That way, normal usage isn't affected, and in times where your mouse is being controlled, constrained or hidden, you can break out of that window and drag/resize windows or simply mouse over a different one without having to be conscious of whether the binding is toggled on or off.

If you're on windows, you can tap the windows key for a very similar effect. Yes, the start menu appears, but other than that your mouse is escaped, its visible and its unconstrained from your current menu and you can do what you like - most people would simply alt-tab but i prefer pressing windows key and moving my mouse to a different window to switch, otherwise im there cycling through 10 different windows constantly.

Am I making sense? Do you think this would be hard to implement? To me it sounds like there's a lot of things going on and it sounds like it'd be easy to break some things in hyprland to implement hence im nervous.

Ashe avatar Mar 05 '24 20:03 Ashe