bedrock icon indicating copy to clipboard operation
bedrock copied to clipboard

refactor(jquery): remove in prototype-nav

Open Haroenv opened this issue 4 years ago • 5 comments

part of #367

Haroenv avatar Jun 09 '21 15:06 Haroenv

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/monocompany/bedrock/HCj3BqhNw1xUydxz6hp82JcS1rd3
✅ Preview: https://bedrock-git-fork-haroenv-feat-jquery-nav-monocompany.vercel.app

vercel[bot] avatar Jun 09 '21 15:06 vercel[bot]

Cool work 😎

Wolfr avatar Jun 10 '21 08:06 Wolfr

L76 .parentElement.classList.contains('br-tree-dir--is-collapsed'); is using a jQuery method (and is also not referencing a class)

Wolfr avatar Nov 29 '21 09:11 Wolfr

Feel free to reopen / merge into a temporary branch you continue on with this work (no need for credit), but I don't have the bandwidth atm to fix those cases :)

Haroenv avatar Nov 29 '21 13:11 Haroenv

Yeah the comment is not for you, it's for myself :D

Feel free to ignore this repo.

Wolfr avatar Nov 29 '21 18:11 Wolfr