ink icon indicating copy to clipboard operation
ink copied to clipboard

fix: handle `#[ink::contract]` with spaces

Open mdqst opened this issue 4 months ago • 3 comments

Summary

Closes #_

  • [n] y/n | Does it introduce breaking changes?
  • [n] y/n | Is it dependent on a specific version of cargo-contract or pallet-revive?

Description

fixed the grep so it finds #[ink::contract] even if it’s indented or has spaces. the old one missed those cases.

Checklist before requesting a review

  • [ ] I have added an entry to CHANGELOG.md
  • [ ] I have commented on my code, particularly in hard-to-understand areas
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • [ ] Any dependent changes have been merged and published in downstream modules

mdqst avatar Aug 26 '25 10:08 mdqst

@mdqst Can you merge master into your PR?

cmichi avatar Aug 29 '25 13:08 cmichi

cmichi, I’m using the web version of GitHub and don’t see the Update branch button. could you clarify if my branch is already up to date with master, or should I update it locally?

mdqst avatar Aug 29 '25 13:08 mdqst

cmichi, I’m using the web version of GitHub and don’t see the Update branch button. could you clarify if my branch is already up to date with master, or should I update it locally?

Your branch is not up to date with master, I'm not sure if you can update it via the web ui.

cmichi avatar Sep 08 '25 22:09 cmichi