ink icon indicating copy to clipboard operation
ink copied to clipboard

chore: update `pallet-revive` in e2e crate

Open AlexD10S opened this issue 6 months ago • 1 comments

Incomplete PR intended to resolve https://github.com/use-ink/ink/issues/2528

With the update of ink-node to use the latest pallet_revive version: https://github.com/use-ink/ink-node/releases/tag/v0.43.3 e2e tests are now failing due to changes in the behavior of the ReviveApi_trace_tx RPC.

Error encountered:

error on ws request `trace_tx`: User(UserError { code: 4003, message: "Client error: Execution failed: Execution aborted due to trap: wasm trap: wasm `unreachable` instruction executed\nWASM backtrace:\nerror while executing at wasm backtrace:\n    0: 0x20b938 - ink_node_runtime.wasm!rust_begin_unwind\n    1: 0xed65 - ink_node_runtime.wasm!core::panicking::panic_fmt::hfdb65cc345fb23df\n    2: 0xd8f78 - ink_node_runtime.wasm!ReviveApi_trace_tx", data: None })

User error: Client error: Execution failed: Execution aborted due to trap: wasm trap: wasm `unreachable` instruction executed
WASM backtrace:
error while executing at wasm backtrace:
    0: 0x20b938 - ink_node_runtime.wasm!rust_begin_unwind
    1: 0xed65 - ink_node_runtime.wasm!core::panicking::panic_fmt::hfdb65cc345fb23df
    2: 0xd8f78 - ink_node_runtime.wasm!ReviveApi_trace_tx (4003)
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

How to Reproduce

To see the issue on master with ink-node v0.43.3:

export CONTRACTS_NODE="path-to-ink-node/ink-node-v0.43.3"
git checkout master
cargo contract test --all-features --manifest-path integration-tests/public/flipper/Cargo.toml --nocapture

Now with the changes of this PR :

git checkout chore/update-revive-e2e-crate 
cargo contract test --all-features --manifest-path integration-tests/public/flipper/Cargo.toml --nocapture

AlexD10S avatar Jun 20 '25 09:06 AlexD10S

🦑 📈 ink! Example Contracts ‒ Changes Report 📉 🦑

These are the results when building the integration-tests/* contracts from this branch with 0 and comparing them to ink! master:

Show Results
Contract Upstream Size (kB) PR Size (kB) Diff (kB) Diff (%) Change
call-builder-return-value 20.807 20.807 0 0 :heavy_minus_sign:
call-runtime 2.195 2.195 0 0 :heavy_minus_sign:
combined-extension 2.51 2.51 0 0 :heavy_minus_sign:
complex-storage-structures 4.296 4.296 0 0 :heavy_minus_sign:
conditional-compilation 1.448 1.448 0 0 :heavy_minus_sign:
contract-invocation 7.935 7.936 0.001 0.0126024 :chart_with_upwards_trend:
contract-invocation/contract1 1.844 1.844 0 0 :heavy_minus_sign:
contract-invocation/contract2 1.804 1.804 0 0 :heavy_minus_sign:
contract-invocation/virtual_contract 4.222 4.222 0 0 :heavy_minus_sign:
contract-invocation/virtual_contract_ver1 1.852 1.852 0 0 :heavy_minus_sign:
contract-invocation/virtual_contract_ver2 1.864 1.864 0 0 :heavy_minus_sign:
contract-storage 18.472 18.471 -0.001 -0.0054136 :chart_with_downwards_trend:
contract-terminate 1.414 1.414 0 0 :heavy_minus_sign:
contract-transfer 3.036 3.036 0 0 :heavy_minus_sign:
contract-xcm 28.206 28.205 -0.001 -0.00354534 :chart_with_downwards_trend:
cross-contract-calls 8.774 8.774 0 0 :heavy_minus_sign:
cross-contract-calls/other-contract 1.524 1.524 0 0 :heavy_minus_sign:
custom-allocator 3.012 2.977 -0.035 -1.16202 :chart_with_downwards_trend:
custom-environment 2.23 2.23 0 0 :heavy_minus_sign:
debugging-strategies 4.086 4.086 0 0 :heavy_minus_sign:
dns 8.058 8.06 0.002 0.0248201 :chart_with_upwards_trend:
e2e-call-runtime 1.674 1.673 -0.001 -0.0597372 :chart_with_downwards_trend:
e2e-runtime-only-backend 2.25 2.25 0 0 :heavy_minus_sign:
erc1155 19.194 19.193 -0.001 -0.00520996 :chart_with_downwards_trend:
erc20 9.446 9.447 0.001 0.0105865 :chart_with_upwards_trend:
erc721 11.034 11.035 0.001 0.0090629 :chart_with_upwards_trend:
events 5.982 5.982 0 0 :heavy_minus_sign:
flipper 1.597 1.597 0 0 :heavy_minus_sign:
incrementer 1.284 1.284 0 0 :heavy_minus_sign:
lang-err/call-builder 8.458 8.457 -0.001 -0.0118231 :chart_with_downwards_trend:
lang-err/call-builder-delegate 3.136 3.136 0 0 :heavy_minus_sign:
lang-err/constructors-return-value 2.225 2.226 0.001 0.0449438 :chart_with_upwards_trend:
lang-err/contract-ref 7.626 7.626 0 0 :heavy_minus_sign:
lang-err/integration-flipper 1.795 1.795 0 0 :heavy_minus_sign:
lazyvec 4.908 4.908 0 0 :heavy_minus_sign:
mapping 9.508 9.508 0 0 :heavy_minus_sign:
mother 13.622 13.622 0 0 :heavy_minus_sign:
multi-contract-caller 12.782 12.782 0 0 :heavy_minus_sign:
multi-contract-caller/accumulator 1.141 1.141 0 0 :heavy_minus_sign:
multi-contract-caller/adder 3.129 3.129 0 0 :heavy_minus_sign:
multi-contract-caller/subber 3.137 3.137 0 0 :heavy_minus_sign:
multisig 24.379 24.379 0 0 :heavy_minus_sign:
own-code-hash 2.204 2.204 0 0 :heavy_minus_sign:
payment-channel 11.014 11.014 0 0 :heavy_minus_sign:
psp22-extension 7.379 7.379 0 0 :heavy_minus_sign:
rand-extension 3.451 3.453 0.002 0.0579542 :chart_with_upwards_trend:
runtime-call-contract 1.527 1.527 0 0 :heavy_minus_sign:
solidity-abi/events 5.248 5.248 0 0 :heavy_minus_sign:
solidity-abi/sol-cross-contract 4.907 4.907 0 0 :heavy_minus_sign:
solidity-abi/sol-cross-contract/other-contract-sol 1.634 1.634 0 0 :heavy_minus_sign:
solidity-abi/sol-encoding 1.56 1.56 0 0 :heavy_minus_sign:
solidity-abi/solidity-calls-flipper 6.253 6.253 0 0 :heavy_minus_sign:
sr25519-verification 0.957 0.957 0 0 :heavy_minus_sign:
static-buffer 2.503 2.503 0 0 :heavy_minus_sign:
storage-types 15.918 15.914 -0.004 -0.0251288 :chart_with_downwards_trend:
trait-dyn-cross-contract-calls 3.579 3.579 0 0 :heavy_minus_sign:
trait-dyn-cross-contract-calls/contracts/incrementer 1.589 1.589 0 0 :heavy_minus_sign:
trait-erc20 9.746 9.747 0.001 0.0102606 :chart_with_upwards_trend:
trait-flipper 1.449 1.449 0 0 :heavy_minus_sign:
trait-incrementer 1.659 1.659 0 0 :heavy_minus_sign:
upgradeable-contracts/delegator 5.877 5.877 0 0 :heavy_minus_sign:
upgradeable-contracts/delegator/delegatee 2.621 2.621 0 0 :heavy_minus_sign:
upgradeable-contracts/delegator/delegatee2 2.62 2.62 0 0 :heavy_minus_sign:
upgradeable-contracts/set-code-hash 1.503 1.503 0 0 :heavy_minus_sign:
upgradeable-contracts/set-code-hash-migration 1.503 1.503 0 0 :heavy_minus_sign:
upgradeable-contracts/set-code-hash-migration/migration 1.67 1.67 0 0 :heavy_minus_sign:
upgradeable-contracts/set-code-hash-migration/updated-incrementer 1.701 1.701 0 0 :heavy_minus_sign:
upgradeable-contracts/set-code-hash/updated-incrementer 1.463 1.463 0 0 :heavy_minus_sign:
wildcard-selector 2.79 2.79 0 0 :heavy_minus_sign:

Link to the run | Last update: Fri Jun 20 12:45:02 CEST 2025

github-actions[bot] avatar Jun 20 '25 10:06 github-actions[bot]

Superseded by https://github.com/use-ink/ink/pull/2541.

cmichi avatar Jul 17 '25 18:07 cmichi