Caller is origin implementation

[ramirez7358]

Summary

Closes #_

• [n] y/n | Does it introduce breaking changes?
• [n] y/n | Is it dependant on the specific version of cargo-contract or pallet-contracts?

Description

Function

caller_is_origin()

Initial status

Not implemented in integration test

Issue documentation & test case

https://github.com/CoinFabrik/on-ink-integration-tests/tree/main/test-cases/caller-is-origin

Implementation note

We have added the depthfield to the ExecContext struct in order to be able to detect caller chages avery time calls are made between contracts.

Basically every time the callee changes in the instantiate_contract or invoke_contract function calls, one is aded to depth. And when the callee returns to the previous one, 1 is subtracted.

The caller_is_origin()function compares the value of depth to zero to check if the current contract caller is the origin of the entire call stack.

Testing guide

In the directory integration-tests/set_contract_storage of the target directory, we include in our pull request a test case showing that the observed implementation difference has been corrected. Note that this test is different from the original test case in our repository, which showed the difference.

In order to run the integration tests run:
cargo test

In order to run the e2e tests run:
cargo test -–features e2e-tests

These tests are run separately because we do not need to compare their results.

Checklist before requesting a review

• [x] My code follows the style guidelines of this project
• [x] I have added an entry to CHANGELOG.md
• [x] I have commented my code, particularly in hard-to-understand areas
• [x] I have added tests that prove my fix is effective or that my feature works
• [x] Any dependent changes have been merged and published in downstream modules

[cmichi]

@ramirez7358 Sorry for pinging you only now about all those old PR's. Could you possibly merge master and resolve the conflicts here as well?

[cmichi]

Thanks for the work on this PR. It took a long while, but we now came to a decision that results in the closing of this PR. Some words on the reasoning and why it took so long:

The project moved out of Parity and with that came a period in which we didn't have funding and things were unclear. We resumed work a while ago to work on ink! v6; this is a migration away from WebAssembly and pallet-contracts to RISC-V and pallet-revive. We wrote down more context about this transition here.

While migrating to pallet-revive, we were uncertain how to handle the off-chain testing environment. We've now decided to remove it in favor of E2E tests against either a full node process or a sandboxed pallet-revive.

The reason for this decision is that the off-chain testing environment comes with a lot of maintenance costs and never fully reflected the on-chain behavior.