website icon indicating copy to clipboard operation
website copied to clipboard

Minor css fix

Open TomNUSDS opened this issue 1 year ago • 6 comments

  • css:sass:watch seemed wrong. Fixed it.
  • Add comment to /assets/stylesheets/application.css
  • Move a person md at root into _draft-people/

TomNUSDS avatar Mar 25 '24 19:03 TomNUSDS

@TomNUSDS OMG finally got this working locally sorry this took so long. In the end: I had to kill all my terminal windows/processes, delete the _site directory, and reboot to get it building correctly. Just ran a bunch of tests editing sass and it's working!

There were a couple moments on my localhost where the live reload didn't totally work and I had to do a hard refresh to see a sass change actually take effect. I wasn't able to consistently replicate so maybe was just the live reload getting ahead of Jekyll compiling stuff? It's still compiling correctly though.

drew-usds avatar Apr 04 '24 04:04 drew-usds

@drew-usds I think I fixed it so the /styles.css isn't in github anymore.

TomNUSDS avatar Apr 15 '24 18:04 TomNUSDS

@drew-usds As far as a slow home page goes, these two carousel image files are really big:

  • images/project-ssa-card.jpg (2MB)
  • images/project-cdc-simple-report-card.jpg (3.9MB)

TomNUSDS avatar Apr 15 '24 18:04 TomNUSDS

As far as a slow home page goes, these two carousel image files are really big:

  • images/project-ssa-card.jpg (2MB)
  • images/project-cdc-simple-report-card.jpg (3.9MB)

@TomNUSDS I can res those down if you want to include that in this PR? Or we could do a separate one with a pass on all the imgs?

drew-usds avatar Apr 17 '24 03:04 drew-usds

Can you down sample if you have time? My other projects are a bit crazy for another week.

I'm also worried I might edit an image that's used by the carousel and main article page.

TomNUSDS avatar Apr 17 '24 15:04 TomNUSDS

@TomNUSDS just added two new commits:

  1. Scales down the images you flagged
  2. Tried commenting out the default Jekyll settings for sass. The local server and build scripts in package.json are still working fine for me and not generating the additional styles.css file. I am not totally sure how this will behave on the GH Pages branch, however. We should test this on staging first.

drew-usds avatar Apr 23 '24 20:04 drew-usds