Uwe Schindler
Uwe Schindler
Cool! I let @rmuir look into it :-)
There is only one issue: For commons-io we have a per-version file. Not sure if we need the same for ICU.
Maybe its time to have some @since annotation in the files...
> even though the JRE is adverse to removing even the most cancerous growths... Oh with @deprecated we have seen removal already. For the @deprecated ones there is a @suppress...
> @uschindler I think the version file would be good, the reason is new calendars get added and so on. I just don't want to have a file for every...
I still have no idea about how to fix versioning. I will open separate issue for that and during that issue "merge" all version specific signatures files into one. About...
Anybody may play and commit ideas to this PR. @rmuir @mikemccand
I removed the vInt-like encoding in ByteBlockPool and BytesRefHash. After that I was able to switch to native shorts.
Great that the original code was still there in a comment. 🤗 This makes easy to review. I don't fully understand the variant that supports negative values. Do we still...
Thanks. So unrolling brings no difference and as the bug is gone, we can replace all of those implementations. About the ByteBufferIndexInput for MMapDirectory: This is really bad, we should...