Albin Hedman
Albin Hedman
Do you want me to reduce the number of commits? If so, then how? One commit or multiple?
I will try to test this, hopefully soonish...
This is still quite the mess, and there are a lot of things I am unsure of. However before I get too far down the road, may I request a...
I just noticed there is https://github.com/esp-rs/esp-hal/pull/255 , perhaps there could be some inspiration to take from there?
Rebased over master and removed duplicate commits from #183
I have now tested `examples/mcpwm-simple.rs` on an ESP32-S3 and it does (after a lot of fixes) seem to work.
Note sure how many TODO's we are comfortable with before merging, there are quite a few still. However I guess the code is perhaps atleast ready to be looked at...
Thanks a lot for the review(s)!
I have now made the two Comparators of every `Operator` mandatory. That way we get rid two of `Operator`'s type parameters. Same thing could be done for the `Generator`s, however...
> There are BTW a bunch of other `Option`-inventing traits throughout the code. I hope you plan to get rid of these as well. If not, let me know, and...