klara icon indicating copy to clipboard operation
klara copied to clipboard

Published 20 hours ago • verified publisher icon usagitoneko97

BREAKING CHANGE: remove py2 support

Open jochman opened this issue 2 years ago • 3 comments

I've removed typed-ast package at there are problems with this package in apple-silicon. Also, typed ast recommends using the builtin ast module from python 3.8 and up.

I could not understand why the uts are failing, I would like to get help to fix those.

jochman avatar Mar 28 '22 08:03 jochman

@usagitoneko97 Hey, what's up?

jochman avatar May 01 '22 06:05 jochman

@usagitoneko97 alive mate?

jochman avatar Aug 01 '22 08:08 jochman

Hi @jochman,

Would it possible to keep the python dependency at python 3.6 and still use the standard ast library? We should handled gracefully the fact that type annotations from comments are not available in python 3.6 and 3.7.

Also there are many more code to cleanup while dropping support for python2. Maybe this can be done later, though.

Are you willing to fork this library and continue maintaining it? I would be down to add support for imports and define a higher level api interface. If you want we can create an organization to host a new repository for klara.

Tell me what you think. Thank

tristanlatr avatar Aug 23 '22 21:08 tristanlatr