intro.js icon indicating copy to clipboard operation
intro.js copied to clipboard

Typescript definitions

Open wouter-leistra opened this issue 3 years ago • 4 comments

Description

Can introjs come with its own official typescript definitions like @types/introjs. There is some externally maintained one going around but when new features are introduced those do not get updated, like when the Got it button hide option was introduced last fall. So we had to start to maintain our own version based on the external one, but it is kind of a messy exercise.

wouter-leistra avatar Jan 24 '22 05:01 wouter-leistra

Sounds good. I was planning on converting the codebase to TS. That would also solve this issue.

afshinm avatar Feb 06 '22 11:02 afshinm

I already did more than a year ago, but there is silence in the pull request https://github.com/usablica/intro.js/pull/1139

s00d avatar Mar 03 '22 16:03 s00d

Yep, sorry about that @s00d. Moving to TS is desirable and that's what I intend to do, but it requires a lot of manual testing. I'm currently working on improving our test coverage (Cypress in particular) which would make this transition easier for us. Thanks again for your patient. I'm hoping to have some updates soon.

afshinm avatar Jul 10 '22 09:07 afshinm

Yep, sorry about that @s00d. Moving to TS is desirable and that's what I intend to do, but it requires a lot of manual testing. I'm currently working on improving our test coverage (Cypress in particular) which would make this transition easier for us. Thanks again for your patient. I'm hoping to have some updates soon.

Hello, updated

s00d avatar Jul 10 '22 13:07 s00d