intro.js icon indicating copy to clipboard operation
intro.js copied to clipboard

intro.js 3.1.0 shows the `introjs-skipbutton` even with `showButtons: false`

Open aried3r opened this issue 4 years ago • 4 comments

Description

In intro.js 3.1.0 the button with the class introjs-skipbutton is shown, even when showButtons is set to false. intro.js 2.9.3 did not have this behavior.

Except for https://github.com/usablica/intro.js/issues/1093 I was unable to find any information to the change in behavior to the buttons in 3.0.0 and 3.1.0.

Expected Behavior

Don't show the skip button when showButtons is set to false.

Actual Behavior

The skip button is shown then showButtons is set to false.

Example (recommended)

Demo with version 3.1.0: https://jsfiddle.net/ta3ex8qw/1/ Demo with version 2.9.3: https://jsfiddle.net/mdvuk638/2/

aried3r avatar Dec 03 '20 13:12 aried3r

Hey @aried3r. That's right. The skip button has been change since v3 and showButtons flag doesn't control the skip button anymore.

I'm happy to add another option to hide the skip button though.

afshinm avatar Dec 03 '20 20:12 afshinm

Would it be possible to add this to the changelog on the releases page and maybe the documentation? It seems there were some behavioral changes from 2.9.3 that haven't been documented (see also #1093).

I'm currently hiding the button and the title via CSS instead, since the title seems to use 10px of space, even if it is not used.

Thanks btw, for keeping this project alive!

aried3r avatar Dec 04 '20 11:12 aried3r

Is there any progress on this? I'd also appreciate an option to hide the skip button

NiushaSedighiK avatar Aug 20 '21 10:08 NiushaSedighiK

I'd also appreciate an option to hide the skip button

Me too!

didaquis avatar Jun 08 '22 16:06 didaquis