usabilla-u4a-android-sdk icon indicating copy to clipboard operation
usabilla-u4a-android-sdk copied to clipboard

Duplicate classes when we want to import com.google.android.play:review:2.0.0

Open tesirb opened this issue 2 years ago • 3 comments

Hello, We would like to import and use the com.google.android.play:review:2.0.0 library but we have some duplicate classes coming from the usabilla lib. We are currently using the version "7.5.1" but we have the same issue with the last one. We could exclude com.google.android.play from your import but we don't like much this solution. Is it possible for you to update your com.google.android.play version ?

Logs :

Duplicate class com.google.android.play.core.common.IntentSenderForResultStarter found in modules jetified-core-1.10.3-runtime (com.google.android.play:core:1.10.3) and jetified-core-common-2.0.0-runtime (com.google.android.play:core-common:2.0.0) Duplicate class com.google.android.play.core.common.LocalTestingException found in modules jetified-core-1.10.3-runtime (com.google.android.play:core:1.10.3) and jetified-core-common-2.0.0-runtime (com.google.android.play:core-common:2.0.0) Duplicate class com.google.android.play.core.common.PlayCoreDialogWrapperActivity found in modules jetified-core-1.10.3-runtime (com.google.android.play:core:1.10.3) and jetified-core-common-2.0.0-runtime (com.google.android.play:core-common:2.0.0) Duplicate class com.google.android.play.core.listener.StateUpdatedListener found in modules jetified-core-1.10.3-runtime (com.google.android.play:core:1.10.3) and jetified-core-common-2.0.0-runtime (com.google.android.play:core-common:2.0.0) Duplicate class com.google.android.play.core.review.ReviewException found in modules jetified-core-1.10.3-runtime (com.google.android.play:core:1.10.3) and jetified-review-2.0.0-runtime (com.google.android.play:review:2.0.0) Duplicate class com.google.android.play.core.review.ReviewInfo found in modules jetified-core-1.10.3-runtime (com.google.android.play:core:1.10.3) and jetified-review-2.0.0-runtime (com.google.android.play:review:2.0.0) Duplicate class com.google.android.play.core.review.ReviewManager found in modules jetified-core-1.10.3-runtime (com.google.android.play:core:1.10.3) and jetified-review-2.0.0-runtime (com.google.android.play:review:2.0.0) Duplicate class com.google.android.play.core.review.ReviewManagerFactory found in modules jetified-core-1.10.3-runtime (com.google.android.play:core:1.10.3) and jetified-review-2.0.0-runtime (com.google.android.play:review:2.0.0) Duplicate class com.google.android.play.core.review.model.ReviewErrorCode found in modules jetified-core-1.10.3-runtime (com.google.android.play:core:1.10.3) and jetified-review-2.0.0-runtime (com.google.android.play:review:2.0.0) Duplicate class com.google.android.play.core.review.model.zza found in modules jetified-core-1.10.3-runtime (com.google.android.play:core:1.10.3) and jetified-review-2.0.0-runtime (com.google.android.play:review:2.0.0) Duplicate class com.google.android.play.core.review.testing.FakeReviewManager found in modules jetified-core-1.10.3-runtime (com.google.android.play:core:1.10.3) and jetified-review-2.0.0-runtime (com.google.android.play:review:2.0.0) Duplicate class com.google.android.play.core.review.zza found in modules jetified-core-1.10.3-runtime (com.google.android.play:core:1.10.3) and jetified-review-2.0.0-runtime (com.google.android.play:review:2.0.0) Duplicate class com.google.android.play.core.review.zzb found in modules jetified-core-1.10.3-runtime (com.google.android.play:core:1.10.3) and jetified-review-2.0.0-runtime (com.google.android.play:review:2.0.0) Duplicate class com.google.android.play.core.review.zzc found in modules jetified-core-1.10.3-runtime (com.google.android.play:core:1.10.3) and jetified-review-2.0.0-runtime (com.google.android.play:review:2.0.0) Duplicate class com.google.android.play.core.review.zzd found in modules jetified-core-1.10.3-runtime (com.google.android.play:core:1.10.3) and jetified-review-2.0.0-runtime (com.google.android.play:review:2.0.0) Duplicate class com.google.android.play.core.review.zze found in modules jetified-core-1.10.3-runtime (com.google.android.play:core:1.10.3) and jetified-review-2.0.0-runtime (com.google.android.play:review:2.0.0) Duplicate class com.google.android.play.core.review.zzf found in modules jetified-core-1.10.3-runtime (com.google.android.play:core:1.10.3) and jetified-review-2.0.0-runtime (com.google.android.play:review:2.0.0) Duplicate class com.google.android.play.core.review.zzg found in modules jetified-core-1.10.3-runtime (com.google.android.play:core:1.10.3) and jetified-review-2.0.0-runtime (com.google.android.play:review:2.0.0) Duplicate class com.google.android.play.core.review.zzh found in modules jetified-core-1.10.3-runtime (com.google.android.play:core:1.10.3) and jetified-review-2.0.0-runtime (com.google.android.play:review:2.0.0) Duplicate class com.google.android.play.core.review.zzi found in modules jetified-core-1.10.3-runtime (com.google.android.play:core:1.10.3) and jetified-review-2.0.0-runtime (com.google.android.play:review:2.0.0)

tesirb avatar Aug 08 '22 09:08 tesirb

Hi @tesirb Thanks for reaching out. com.google.android.play libraries were separated into different ones by functionality in order to reduce the size of the core from v2.0.0. Therefore, this is a breaking change for us and we still need to make another release and need some time before the next breaking change update. Therefore, I see that you already mention you don't like this solution, would you consider excluding our dependency, until we do the upgrade? Thank you. Best Regards.

demirsoya avatar Aug 16 '22 11:08 demirsoya

Hi @demirsoya

I'm @tesirb's coworker and I'm checking with you to see if you could eventually provide a future new release date so that we can anticipate our next deployments.

Unfortunately we do not wish to exclude the dep. especially if it brings breaking changes into your sdk. We cannot risk to have Usabilla integration being malfunctioning after our next update.

Have a nice day. Regards.

Marine J

MarineJu avatar Aug 30 '22 07:08 MarineJu

Hi @MarineJu , We are working on that and planning to update play libraries to 2.0.0 version with the next major release. Regards, Anday

demirsoya avatar Sep 05 '22 08:09 demirsoya