activejob-google_cloud_pubsub

activejob-google_cloud_pubsub copied to clipboard

Fix compatibility issue since gem version 0.34.0 google google-cloud-pubsub

2

Since the 1st of February in 2019, gem google-cloud-pubsub has been updated (0.34.0 version) and it brokes compatibility with this current gem. Extract from google-cloud-pubsub's changelog, 0.34.0 version : *...

tracyloisel

Hello, Firstly, thank you for this gem. I'm hoping to get some good use out of it. I am attempting to use this gem in my app as a drop-in...

jgunnink

Too many thread pools

2

[google-cloud-pubsub](https://github.com/GoogleCloudPlatform/google-cloud-ruby/blob/google-cloud-pubsub/v0.30.0/google-cloud-pubsub/lib/google/cloud/pubsub/subscriber.rb#L108-L110) is starting a thread pool to process incoming messages: ```ruby @stream_pool.map do |stream| Thread.new { stream.start } end ``` [activejob-google_cloud_pubsub](https://github.com/ursm/activejob-google_cloud_pubsub/blob/master/lib/activejob-google_cloud_pubsub/worker.rb#L25) is doing the same: ```ruby pool = Concurrent::ThreadPoolExecutor.new(min_threads: @min_threads,...

mattes

No thread mode

1

for better scalability control, it's better if the worker run on single thread `--max-threads=N` cannot be used because the worker will consume all the messages, and reschedule then, running with...

hellupline