Stephan Hügel comments

Results 272 comments of


                                            Stephan Hügel

Panic in polygon difference

I’m out of action (🤒) rn, but we might try testing these errors against HEAD to see whether the recent fixes are relevant here?

GeodesicBearing produces NAN when y value is outside of [-90, 90]

I'll be conservative and say out of bounds long should also be an Err as it might indicate problems with the input data – it's better to draw attention to...

Panic due to integer overflow in Line::delta logic, and thus Line::slope

> determine if three coords are a triangle Any three points that aren't collinear form a triangle, right? You could use https://docs.rs/robust/0.2.3/robust/fn.orient2d.html and check for a non-zero value. Or if...

Panic due to integer overflow in Line::delta logic, and thus Line::slope

> Seems odd the geo-types package doesnt have a way to determine of a geo_types::Triangle is a triangle. I'd rather not have another dependency just for that. `geo-types` provides types,...

Performance improvements for Graham's scan

Similar to my comment in #1057, could you say a little about how this improvement works?

Panic in BooleanOps::union for Polygon<f32>

@RobWalt Could you add this to your draft Bool ops PR as a test case?

Implement RTreeObject for Geometry enum

I vastly prefer the shared version, so that's incorporated now. In terms of tests, I want to make sure we're testing 1. `GeometryCollection`s with empty envelopes, since _I think_ that's...

Implement RTreeObject for Geometry enum

I have just realised that we also need to impl `PointDistance` which has really ruined my day.

Implement RTreeObject for Geometry enum

It certainly works, but everything other than the envelope-based queries require `PointDistance`. So I don't know where to go from here. I'm happy to add some more tests, write the...

Implement RTreeObject for Geometry enum

> Given #1029 it can be quite simple to implement `PointDistance` for all geometry type such as > > ```rust > impl PointDistance for Geometry { > fn distance_2( >...