urql icon indicating copy to clipboard operation
urql copied to clipboard

changed to use setInterval in test

Open jatkz opened this issue 3 years ago • 1 comments

Summary

I want to fix a typo in documentation

Set of changes

The test seems to be checking on an interval for if the observable pipe subscription is mutating on an interval. The code used setTimeout and I changed to setInterval otherwise the test would never reach done()

jatkz avatar Jul 28 '22 00:07 jatkz

⚠️ No Changeset found

Latest commit: b4d985b4d6f286ee48c5ab9380c098ecd012e637

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

changeset-bot[bot] avatar Jul 28 '22 00:07 changeset-bot[bot]

Closing since this didn't receive activity in the discussion thread. FWIW, when only a single "signal" is tested, I'd never want to resort to an interval, since it's just not what's being tested. Even using setTimeout without mock timers, feels like code smell, imho, so I wouldn't outright recommend it.

kitten avatar Jan 10 '23 16:01 kitten