do_restore_write_mbr without fixing_gpt flag

Open cagnulein opened this issue 1 year ago • 2 comments

as referenced here https://forums.urbackup.org/t/writing-gpt-backup-header-failed-error-on-restore/14451 I guess the code in the client_restore.cpp it was outdate about the fix mbr parameter.

Jun 18 '24 15:06 cagnulein

The parameter is false in non-restore CD cases because there is no guarantee that sgdisk is available and the "fix" liberally relies on this.

Perhaps we can make the fix a parameter that is false by default?

Jun 23 '24 12:06 uroni

The parameter is false in non-restore CD cases because there is no guarantee that sgdisk is available and the "fix" liberally relies on this.

Perhaps we can make the fix a parameter that is false by default?

or maybe we can test the presence of sgdisk and set the parameter based on this and also maybe outputting something about this on the terminal?

Jun 24 '24 06:06 cagnulein