fastapi-pagination icon indicating copy to clipboard operation
fastapi-pagination copied to clipboard

Move extensions to separate packages

Open uriyyo opened this issue 3 years ago • 3 comments

Extensions:

  • [ ] async_sqlalchemy
  • [ ] async_sqlmodel
  • [ ] asyncpg
  • [ ] databases
  • [ ] django
  • [ ] gino
  • [ ] mongoengine
  • [ ] motor
  • [ ] orm
  • [ ] ormar
  • [ ] piccolo
  • [ ] sqlalchemy
  • [ ] sqlalchemy_future
  • [ ] sqlmodel
  • [ ] tortoise

uriyyo avatar Apr 09 '22 13:04 uriyyo

Possibly include Beanie which seems like an excellent candidate in that it extends Motor and Pydantic and works well with FastApi.

johnziebro avatar Jun 12 '22 00:06 johnziebro

I have created new issue for beanie #334 before find proposal here. Solution will coming soon.

TamiasSibiricus avatar Jul 05 '22 14:07 TamiasSibiricus

But is it real requirement to move extensions each one to separate package? In this case each package will contain only one file with one function. Seems like hyperfragmentation and hard to maintain. I think any coder can write own extension and just pull request here.

TamiasSibiricus avatar Jul 05 '22 14:07 TamiasSibiricus

@TamiasSibiricus Because of gino package there were dependency conflicts between other packages. After removing it from the dependencies list seems like this issue is no longer needed.

uriyyo avatar Sep 04 '22 14:09 uriyyo