fastapi-pagination icon indicating copy to clipboard operation
fastapi-pagination copied to clipboard

Add ability to use cursor pagination with beanie

Open shepilov-vladislav opened this issue 1 year ago • 2 comments

shepilov-vladislav avatar Aug 16 '24 10:08 shepilov-vladislav

Codecov Report

Attention: Patch coverage is 56.09756% with 18 lines in your changes missing coverage. Please review.

Project coverage is 93.62%. Comparing base (b74d092) to head (f8fe463). Report is 10 commits behind head on main.

Files with missing lines Patch % Lines
fastapi_pagination/ext/beanie.py 56.09% 18 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1249      +/-   ##
==========================================
- Coverage   94.39%   93.62%   -0.77%     
==========================================
  Files          38       38              
  Lines        1427     1459      +32     
==========================================
+ Hits         1347     1366      +19     
- Misses         80       93      +13     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Aug 16 '24 17:08 codecov[bot]

@uriyyo I also added a backwards pass with testing, but I can't figure out why it works for Document and doesn't work for Document.find()

shepilov-vladislav avatar Aug 26 '24 17:08 shepilov-vladislav

What's the status on this PR?

gilad9366 avatar Dec 03 '24 16:12 gilad9366

Hi @shepilov-vladislav,

Sorry for long response, are you sitll interested in this PR? Could you please resolve conflicts? I would like to merge this PR.

uriyyo avatar Feb 02 '25 14:02 uriyyo

@uriyyo Updated!

shepilov-vladislav avatar Feb 07 '25 13:02 shepilov-vladislav

Thanks 🙌

uriyyo avatar Feb 07 '25 16:02 uriyyo