אורי
אורי
Can you please review this PR?
Hi, I can confirm that I have tested this new command in production and it works. It deletes thumbnails older than `settings.THUMBNAIL_CLEANUP_DELETE_TIMEOUT` seconds and doesn't delete thumbnails newer than `settings.THUMBNAIL_CLEANUP_DELETE_TIMEOUT`...
> Instead of having yet another setting, what about allowing the timeout be specified on the command line? It could still default to 10 years when not specified, but `python...
> I wrote tonight an alternative patch that would avoid new command and setting, by adding an option to `clear_delete_referenced`. Can you look at it and tell if it would...
> > > I think clear_delete_referenced will delete almost all thumbnails if run without any command line argument, and its risky > > We could mitigate that risk by requiring...
> > Yes but I may run the current version which if run without the `--timeout` option, will delete all my thumbnails. > > Not if the `--timeout` option becomes...
> I added a management command to delete the cache, kvstore (database) and storage (filesystem) if the file's created time is before `THUMBNAIL_CACHE_TIMEOUT` seconds ago in #724. You can use...
Hi Aaron. @claudep is not responding, so let's make a decision. I think you can define a new setting for the new action you added, which will be the number...
@acjh Also, please update https://github.com/jazzband/sorl-thumbnail/blob/master/docs/management.rst with the documentation for the new command in your PR. Is this taken as it is to https://sorl-thumbnail.readthedocs.io/en/latest/management.html? And also, if relevant please create tests...