cli icon indicating copy to clipboard operation
cli copied to clipboard
verified publisher icon urfave

Update GitHub Actions (bump versions, improve naming a bit)

Open bartekpacia opened this issue 1 year ago • 4 comments

What type of PR is this?

  • cleanup / CI

What this PR does / why we need it:

This PR updates all GitHub Actions we use to the latest versions. GitHub is phasing out Node.js 16 so actions have to be updated.

I also added the staticcheck linter, enabled. I've been using staticcheck for many years in my personal Go projects and it's a very useful tool. It also works great with golangci-lint.

Which issue(s) this PR fixes:

None

Special notes for your reviewer:

None

Testing

This is a change related itself to testing.

Release Notes

None.

bartekpacia avatar Apr 30 '24 19:04 bartekpacia

Sorry about the conflict, @bartekpacia!

meatballhat avatar Apr 30 '24 23:04 meatballhat

@meatballhat no problem, resolved it :)

bartekpacia avatar Apr 30 '24 23:04 bartekpacia

@meatballhat "diffcheck" is failing. I suppose the action here is to update godoc-current.txt, right? The changes in this PR are not breaking, it's just some receiver/args renaming)

bartekpacia avatar Apr 30 '24 23:04 bartekpacia

@meatballhat "diffcheck" is failing. I suppose the action here is to update godoc-current.txt, right? The changes in this PR are not breaking, it's just some receiver/args renaming)

Yep this is a bit clunky, but meant to guard against accidentally doing something not-semver. You can run make v3approve and commit + push the change if it looks good to you 👍🏼

meatballhat avatar May 01 '24 00:05 meatballhat