cli icon indicating copy to clipboard operation
cli copied to clipboard

Published 20 hours ago • verified publisher icon urfave

Make *cli.Context implement context.Context by renaming Value

Open marwan-at-work opened this issue 2 years ago • 3 comments

This PR runs the gopls rename function on the *cli.Context.Value method to be renamed to GetValue. This makes the *cli.Context implement context.Context by default as the interface is already embedded into the struct, the only reason it didn't implement it before was because of that method name conflicting in the signature.

See https://github.com/urfave/cli/issues/833#issuecomment-1328067910

marwan-at-work avatar Nov 26 '22 16:11 marwan-at-work

@marwan-at-work Can you rebase main ?

dearchap avatar Jun 18 '23 14:06 dearchap

The description doesn't say WHY you want cli.Context to implement context.Context. What value does this bring? I only see bugs and confusion coming...

dolmen avatar Dec 22 '23 07:12 dolmen

This PR changes a lot of code, there are tons of merge conflicts, and v2 is effectively in maintenance mode right now.

I'm leaning toward closing this PR, but would like to hear @meatballhat / @dearchap / @Juneezee opinion first.

bartekpacia avatar May 01 '24 00:05 bartekpacia

Yes I agree with @bartekpacia . There is no need for this anymore given that v3 has moved to a different architecture. v2 is in maint mode. I am going to close this.

dearchap avatar Jun 30 '24 14:06 dearchap