landscape
landscape copied to clipboard
urbit
Move linting & prettier checks to CI pipeline
commit: urbit/urbit@c5393bc
There are a litany of woes surrounding Husky, in which our pre-commit TS lint and formatting hook results in poor developer experience and lots of frustration.
From @eamsden:
CI is the place to enforce QA, but it should be possible for developers to easily run the same QA checks locally git hooks are a very bad place to enforce QA, as they then militate against a major use of [VCS] which is to commit often so you don't lose experimental/draft work.
From @Fang- :
hah i actually got frustrated and nuked my urbit/urbit/.git/hooks yesterday
From @philipcmonk, perhaps most salient:
about ready to murder whoever added husky don't even know what it does, it just always causes pain git checkout should always succeed
Three strikes is an issue, so let's investigate moving this step to the CI pipeline, rather than as a pre-commit hook.
Afaik we've been using it for a while in landscape. I then added it to btc-wallet and that triggered a conversation about how to manage it globally, which resulted in this PR: https://github.com/urbit/urbit/pull/5073
Quoth @liam-fitzgerald:
The correlation between Landscape's quality and the stringency of the CI system is nearly 1:1. Let's fix this for real. Please.