ares icon indicating copy to clipboard operation
ares copied to clipboard

CI: add test to boot fakezod with -x and check return code

Open eamsden opened this issue 1 year ago • 4 comments

CI should attempt to boot a fakezod as an integration test.

Open questions:

  • [ ] Where do we get a patched king for CI to run?
  • [ ] Should this run on
    • status branch merges?
    • All open PRs?
    • ready-for-review PRs?
    • reviewed PRs?

eamsden avatar Dec 08 '23 19:12 eamsden

Where do we get a patched king for CI to run?

This question is being resolved by @eamsden in Vere #566

I think the integration test should automatically run only on status branch merges, but there should be an on-demand test that reviewers can run / request for a given PR / branch.

ashelkovnykov avatar Dec 11 '23 17:12 ashelkovnykov

@urbit/runtime what do we need to do to have a prebuilt binary of vere with that functionality easily accessible to Ares CI?

eamsden avatar Dec 16 '23 01:12 eamsden

@eamsden Pull latest stable Vere release from urbit.org?

ashelkovnykov avatar Dec 17 '23 16:12 ashelkovnykov

@ashelkovnykov there's a couple of issues. The first is that that PR is not merged yet. The second is that Vere assumes that it will run with Vere as its serf, which is fine for normal operations, but is not fine in what we might call "yeoman" mode, where the user-invoked Vere simply loads the snapshot itself. This is done for several of the subcommands, for instance for ./urbit pack and ./urbit meld among others.

eamsden avatar Dec 17 '23 21:12 eamsden