react-map-gl-draw icon indicating copy to clipboard operation
react-map-gl-draw copied to clipboard

modeOptions are not applied on initial Draw creation

Open riazjahangir opened this issue 4 years ago • 0 comments

I have defined a custom draw mode as described at https://github.com/mapbox/mapbox-gl-draw/blob/main/docs/MODES.md#available-custom-modes.

The custom mode makes use of modeOptions in its onSetup function, but these are not being passed via the modeOptions attribute of Draw as I would have expected.

Essentially I have:

<Draw
  mode="my_custom_mode"
  modeOptions={modeOptions}
  modes={(defaultModes) => ({
     ...defaultModes,
     my_custom_mode: MyCustomMode,
   })}
...

Looking at the source, it seems that modeOptions are only passed on component update, not on initial mount, so modeOptions cannot be used with the default mode.

riazjahangir avatar Jan 25 '21 21:01 riazjahangir