netimpair
netimpair copied to clipboard
urbenlegend
Turn netimpair into a package!
Hey @urbenlegend I went ahead and did this since I needed it anyway. This addresses #5.
I also have some more commits which update the readme and separate out the CLI stuff into a separate submodule.
I'll push that up soon!
@urbenlegend I did a little reorganization of the CLI related code into a new submodule as well. This makes a little more clear the distinction between the underlying Python API and the CLI app which consumes it. I also updated the readme to reflect the new CLI usage as a system utility via the setuptools entry point (i.e. $ sudo ./netimpair.py just becomes plain old sudo netimpair).
Let me know what you think! :)
@urbenlegend any chance you looked at this? I'd love not to have to maintain our own fork ;)
Hi @tgoodlet , yes I have been looking through it. Not done yet because something at work came up, I will look at it this Friday or Saturday.
@urbenlegend great :)
Sorry didn't mean to rush you!
Oh just realizing now that the diff is quite big because I created new files. Note that I didn't actually change that much code (checkout the branch and do a git blame to see that the original authors are still there) but it just looks like that because Github isn't following the change set across files... :(
The commits here and here show the bulk of the actual change set. The rest is just the readme tweak and CLI module creation which you can follow here.
Let me know if you want me to improve anything or make it clearer :)
@goodboy This repository seems to be abandoned. Would you accept PRs in your fork? That kind of means you are the maintainer then. The work load seems to be manageable though.
@ChristofKaufmann sorry about the huge delay on responding but actually it's quite possible we might be interested in taking this over.
Let me get back to you after discussion with my collabs since we may have a use for this yet again.
Oh my goodness, so sorry for the delay. I totally forgot about this project for a while. I took a 3 and half year break from software engineering to pursue photography and filmmaking, but due to COVID shutting down everything, the state of the economy in the US, and rising COVID rates again, I've decided to go back.
I am willing to maintain this project again since this time I'll be back in engineering for good, but I also understand that 4 years of not checking my GitHub projects is a pretty crap response time for anyone depending on this. I probably destroyed some developer good will in the process and I humbly apologize for this.
So @goodboy let me know what you want to do. I can maintain this going forward now that I'll be doing this full time, but I'll also understand if you and your team want to maintain your own fork. In the meantime, I'll look at the PR.
@urbenlegend nice to have you back :smile_cat:
I actually went through the same type of thing but with a music project over the last couple years so I totally understand where you're coming from :+1:
I would much prefer to have the original author maintain (yes you friend) since I have my own growing slew of ambitious projects to maintain at the moment :laughing:
I'm happy to help get this code base to wherever you'd like it as well. I actually do have recent need for it in testing the new actor model I'm working on.
@goodboy Sounds good. I will start maintaining this project again then! Thanks for understanding.