netimpair icon indicating copy to clipboard operation
netimpair copied to clipboard

Make an importable package?

Open goodboy opened this issue 8 years ago • 4 comments

Hey @urbenlegend,

I'm very interested in using this code as part of a remote control tool for shaping traffic between nodes in a cluster.

Would you be open to a PR which properly packages this as an importable module and also adds support for remote tc invocation over ssh and via rpyc?

goodboy avatar Dec 01 '16 16:12 goodboy

Wonderful! I'll take a look at this.

urbenlegend avatar Dec 03 '16 04:12 urbenlegend

@urbenlegend I was just reading the source code of xonsh and noticed that they claim using console_scripts can be slow.

I haven't noticed any lag and I know a lot of projects use it. If you try it out and find it's not suitable we can find an alternative.

goodboy avatar Dec 03 '16 17:12 goodboy

I'd be very happy to have a package in pypi and was coming here to see if anyone else had filed a bug/PR (thanks tgoodlet!). I want to reuse the library in an app I'm writing for destructive testing since it does what I want better than I would have done it (and thanks urbenlegend for that!) and would like to toss the thing in my requirements.

I'm not sure where xonsh came to their conclusions. Maybe an older version of setup_tools?

The script setup_tools generates on my system looks like

#!/path/to/python2.7

# -*- coding: utf-8 -*-
import re
import sys

from foo import bar

if __name__ == '__main__':
    sys.argv[0] = re.sub(r'(-script\.pyw|\.exe)?$', '', sys.argv[0])
    sys.exit(bar())

For some given foo, bar, and python interpreter.

mmessmore avatar Dec 09 '16 03:12 mmessmore

@mmessmore glad to hear the work is useful :) I was thinking @urbenlegend could push to pypi after this PR gets in!

goodboy avatar Dec 09 '16 03:12 goodboy